The ``can_delete`` argument of ``generic_inlineformset_factory`` isn't working

[Piaume]

When the can_delete argument of generic_inlineformset_factory is set to False, a "Delete" checkbox is always displayed on the admin site.

Here a short example:

class SomeModel(models.Model):
    content_type = models.ForeignKey(ContentType)
    object_id = models.PositiveIntegerField()
    content_object = generic.GenericForeignKey('content_type', 'object_id')

class SomeInlineFormset(generic.GenericStackedInline):
    model = SomeModel
    formset = generic.generic_inlineformset_factory(SomeModel, can_delete=False)
    extra = 0

class SomeModelAdmin(admin.ModelAdmin):
    inlines = [SomeInlineFormset]

​http://img8.imageshack.us/img8/3323/screenshotbe.png

[Piaume]

Bug result on the admin site (there is a "Delete" checkbox)

[Russell Keith-Magee]

It's probably not the reason for your original report, but the admin UI merge seems to have completely broken Generic inline formsets. I can't get them to work at all, with or without can_delete.

[Natalia Bidart]

Submitting patch to have InlineModelAdmin.get_formset passing can_delete and can_order to inlineformset_factory.

Tests are also included, but not for can_order. I couldn't find a way to test it, since the admin GUI looks the same when can_order is either True or False. Ideas are welcomed!

[Natalia Bidart]

Improved the tests. Added default values on parent class for can_delete and can_order. Ran the whole test suite, all green.

[jkocherhans]

(In [12533]) Fixed #12561. InlineAdmin now respects can_delete=False. Thanks, nessita.

[jkocherhans]

(In [12534]) [1.1.X] Fixed #12561. InlineAdmin now respects can_delete=False. Backport of [12533] from trunk.

[Jacob]

Milestone 1.2 deleted