ModelChoiceField.clean call to_python and validate from ChoiceField

[Petr Marhoun <petr.marhoun@…>]

Comment in ModelChoiceField says: This class is a subclass of ChoiceField for purity, but it doesn't actually use any of ChoiceField's implementation.

But with model level validation method ModelChoiceField.clean calls Field.clean and it calls self.to_python and self.validate, in reality ChoiceField.to_python and ChoiceField.validate. And for ModelChoiceField these methods are useless and can be harmful - for example (my problem) with hidden ModelChoiceField choices were not created but they are now, it could be very ineffective.

[Honza Král]

Thanks, could you provide some tests for this behavior?

[Petr Marhoun <petr.marhoun@…>]

I attached test - it is quite artificial ("problem" in test could be solved with simple "select_related" in queryset), but it should prove that choices are really generated.

[Honza Král]

Changed tests to UnitTest, simplified them a bit.

[Honza Král]

Added a simpler test case in unittest format...

[jkocherhans]

(In [12211]) Fixed #12510. Changed ModelChoiceField to stop using some of its superclasses implementation. This could cause more than one query when generating choices. Thanks, Petr Marhoun and Honza Kral.

[Jacob]

Milestone 1.2 deleted