Opened 6 years ago

Closed 5 years ago

#12469 closed (fixed)

get_urls docs in ModelAdmin can be extended

Reported by: benc Owned by: nobody
Component: Documentation Version: 1.1
Severity: Keywords: get_urls ModelAdmin
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by russellm)

It might help to explain three things regarding custom views in ModelAdmin
http://docs.djangoproject.com/en/dev/ref/contrib/admin/#django.contrib.admin.ModelAdmin.get_urls

  1. The path in the example r'^my_view/$' will be accessed at /admin/myapp/mymodel/my_view/
  1. self.my_view in the example means that you probably want to define the view inside the MyModelAdmin Class so it has access to the ModelAdmin.
  1. my_view will be called with the request and the ModelAdmin instance as arguments:

def my_view(request, model_admin):

A simple class with get_urls and a view will be best.
Thanks

Change History (2)

comment:1 Changed 5 years ago by russellm

  • Description modified (diff)
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 5 years ago by timo

  • Resolution set to fixed
  • Status changed from new to closed

(In [15113]) Fixed #12469 - Add a few clarifications to the ModelAdmin.get_urls() docs. Thanks benc for the suggestions.

Note: See TracTickets for help on using tickets.
Back to Top