#12466 closed (fixed)
required class are also added to not required fields
Reported by: | Owned by: | Jannis Leidel | |
---|---|---|---|
Component: | Forms | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Pull Requests: | How to create a pull request | ||
Description ¶
Since [11830] there is the option to add css classes for errors and for required fields. But there is a error in the implementation. If you have a model with a few fields and there is a required field before a non required field the non required fields will also be given an "required" class.
This is a bug because the initialization of the variable which stores the classes is only initialize once before the for loop.
Change History (8)
by , 15 years ago
Attachment: | patch_css_classes.diff added |
---|
comment:1 by , 15 years ago
Needs tests: | set |
---|---|
Triage Stage: | Unreviewed → Accepted |
The patch looks correct to me, can you write up a simple test for this?
comment:2 by , 15 years ago
Needs tests: | unset |
---|
comment:3 by , 15 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:4 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
patch for this issue