#12398 closed (fixed)
Add `TypedMultipleChoiceField` to compliment `TypedChoiceField`.
Reported by: | Tai Lee | Owned by: | nobody |
---|---|---|---|
Component: | Forms | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Patch includes docs and tests. This could also fix #5481.
Attachments (2)
Change History (10)
by , 15 years ago
Attachment: | 12398-TypedMultipleChoiceField-r11901.diff added |
---|
comment:1 by , 15 years ago
comment:2 by , 15 years ago
Triage Stage: | Unreviewed → Accepted |
---|---|
Version: | SVN |
comment:3 by , 14 years ago
Patch needs improvement: | set |
---|
by , 14 years ago
Attachment: | 12398-TypedMultipleChoiceField-r14586.diff added |
---|
comment:4 by , 14 years ago
Patch needs improvement: | unset |
---|---|
Triage Stage: | Accepted → Ready for checkin |
Version: | → SVN |
I've updated the patch according to your feedback. The underlying implementation changed a fair bit (to use to_python()
instead of clean()
), so the "hack" comment is gone as it was no longer relevant, anyway. The tests were named for consistency with the surrounding tests back then, which had a unique sequential number suffix for all tests in the module, rather than for each group of tests.
I think we can also mark #5481 as fixed or invalid (with instruction to use TypedMultipleChoiceField
) now?
comment:5 by , 14 years ago
milestone: | → 1.3 |
---|
comment:6 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Looks fairly good to me. A few things:
With these addressed, feel free to move to Ready For Checkin.