Code

Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#1235 closed defect (fixed)

[patch] [magic-removal] Django can''t send e-mail in other encoding than ''us-ascii''

Reported by: igor@… Owned by: adrian
Component: Core (Other) Version:
Severity: minor Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I think it would be very useful if it was possible to send e-mail (using 'django.core.mail') in something different than 'us-ascii', for example, in 'utf-8' by default (using DEFAULT_CHARSET variable).

The patch will be included.

Attachments (2)

django-mail-charset-support.diff (1.2 KB) - added by igor@… 8 years ago.
patch for support different charsets in mail messages
django-mail-charset-support.2.diff (1.1 KB) - added by akaihola 8 years ago.
magic-removalized version of the patch, with Header() import

Download all attachments as: .zip

Change History (18)

Changed 8 years ago by igor@…

patch for support different charsets in mail messages

comment:1 Changed 8 years ago by hugo

what is this Header() call you are using? Shouldn't it be imported from somewhere (or defined somehow)? Can't find it in the core/mail.py or in your patch.

comment:2 Changed 8 years ago by igor@…

Arhhh. Very sorry.

Forgot to include importion of email.Header.Header:

from email.Header import Header

comment:3 Changed 8 years ago by hugo

Ok. That one does handle quoted-printable-encoding correctly, so I am +1 on this patch.

comment:4 Changed 8 years ago by alex.smudgy@…

And when can we wait for patch in django-release ?

Changed 8 years ago by akaihola

magic-removalized version of the patch, with Header() import

comment:5 Changed 8 years ago by akaihola <antti.kaihola@…>

  • Summary changed from Django can't send e-mail in other encoding than 'us-ascii' to [patch] [magic-removal] Django can't send e-mail in other encoding than 'us-ascii'

comment:6 Changed 8 years ago by adrian

  • priority changed from normal to low
  • Severity changed from normal to minor

comment:7 Changed 8 years ago by igor@…

Adrian, why is it a minor/low issue? Please believe me it is very important for people who use not only latin1 charset (i.e. Russians).

When this patch will appear in the mainstream?

Thank you.

comment:8 Changed 8 years ago by dottedmag@…

I also don't think that ignoring everyone except English-speaking people is the 'minor' issue with 'low' priority. It's even not Latin1 charset which would be ok for some europeans, it is US-ASCII, which is sufficient only for English.

comment:9 Changed 8 years ago by unatine@…

When this patch appear in trunk?
It's very important for non-English speaking users.

comment:10 Changed 8 years ago by timochka@…

I want messages in UTF-8! I'm +1 for this patch

comment:11 Changed 8 years ago by mblsha

It would be cool to support unicode when sending mail, so Django would be on par with Rails in this case.

comment:12 Changed 8 years ago by jacob

What, did you guys organize a write-in campaign or something? :)

comment:13 Changed 8 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [2901]) Fixed #1235: email sent from django.core.mail will now be encoded using
the value of the DEFAULT_CHARSET setting. Thanks, igor@… and akaihola.

comment:14 Changed 8 years ago by anonymous

  • Summary changed from [patch] [magic-removal] Django can't send e-mail in other encoding than 'us-ascii' to [patch] [magic-removal] Django can''t send e-mail in other encoding than ''us-ascii''

comment:15 follow-up: Changed 5 years ago by call_of_duty_6

hello! thank you for veru userfull info. see also here *rapidshare file search

comment:16 in reply to: ↑ 15 Changed 5 years ago by call_of_duty_6

Replying to call_of_duty_6:

see also here *rapidshare file search

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.