Opened 7 years ago

Closed 3 years ago

Last modified 3 years ago

#12346 closed Bug (fixed)

Docs should cover validaton of model inline formsets

Reported by: johnsmith Owned by: nobody
Component: Documentation Version: 1.1
Severity: Normal Keywords: inlineformset_factory, BaseInlineFormSet validation
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

http://docs.djangoproject.com/en/dev/topics/forms/modelforms/#inline-formsets

Should mention that BaseInlineFormSet should be subclassed in order to add a custom clean method

Attachments (1)

12346.diff (4.2 KB) - added by Tim Graham 3 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by Russell Keith-Magee

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

Good idea, wrong place. The first line of the InlineFormSet docs say that InlineFormSets are "a small abstraction layer on top of model formsets", so the right place to document this is in ModelFormSets. There currently isn't any mention of the fact that ModelFormSets call the clean method on constituent forms.

comment:2 Changed 5 years ago by Matt McClanahan

Severity: Normal
Type: Bug

comment:3 Changed 5 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:4 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

Changed 3 years ago by Tim Graham

Attachment: 12346.diff added

comment:5 Changed 3 years ago by Tim Graham

Has patch: set

comment:6 Changed 3 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In 181f63c22dc0de823031be84b86277b282e4e221:

Fixed #12346 -- Added a note on how to validate InlineFormSets.

Thanks johnsmith for the suggestion.

comment:7 Changed 3 years ago by Tim Graham <timograham@…>

In cf8d0933cb5bba3ce869f55cd423054d9c128956:

[1.6.x] Fixed #12346 -- Added a note on how to validate InlineFormSets.

Thanks johnsmith for the suggestion.

Backport of 181f63c22d from master

comment:8 Changed 3 years ago by Tim Graham <timograham@…>

In abce5abe6686551e68f7e8a663f8918c56d307b1:

[1.5.x] Fixed #12346 -- Added a note on how to validate InlineFormSets.

Thanks johnsmith for the suggestion.

Backport of 181f63c22d from master

Note: See TracTickets for help on using tickets.
Back to Top