Opened 15 years ago

Closed 11 years ago

Last modified 11 years ago

#12346 closed Bug (fixed)

Docs should cover validaton of model inline formsets

Reported by: johnsmith Owned by: nobody
Component: Documentation Version: 1.1
Severity: Normal Keywords: inlineformset_factory, BaseInlineFormSet validation
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

http://docs.djangoproject.com/en/dev/topics/forms/modelforms/#inline-formsets

Should mention that BaseInlineFormSet should be subclassed in order to add a custom clean method

Attachments (1)

12346.diff (4.2 KB ) - added by Tim Graham 11 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by Russell Keith-Magee, 15 years ago

Triage Stage: UnreviewedAccepted

Good idea, wrong place. The first line of the InlineFormSet docs say that InlineFormSets are "a small abstraction layer on top of model formsets", so the right place to document this is in ModelFormSets. There currently isn't any mention of the fact that ModelFormSets call the clean method on constituent forms.

comment:2 by Matt McClanahan, 14 years ago

Severity: Normal
Type: Bug

comment:3 by Aymeric Augustin, 13 years ago

UI/UX: unset

Change UI/UX from NULL to False.

comment:4 by Aymeric Augustin, 13 years ago

Easy pickings: unset

Change Easy pickings from NULL to False.

by Tim Graham, 11 years ago

Attachment: 12346.diff added

comment:5 by Tim Graham, 11 years ago

Has patch: set

comment:6 by Tim Graham <timograham@…>, 11 years ago

Resolution: fixed
Status: newclosed

In 181f63c22dc0de823031be84b86277b282e4e221:

Fixed #12346 -- Added a note on how to validate InlineFormSets.

Thanks johnsmith for the suggestion.

comment:7 by Tim Graham <timograham@…>, 11 years ago

In cf8d0933cb5bba3ce869f55cd423054d9c128956:

[1.6.x] Fixed #12346 -- Added a note on how to validate InlineFormSets.

Thanks johnsmith for the suggestion.

Backport of 181f63c22d from master

comment:8 by Tim Graham <timograham@…>, 11 years ago

In abce5abe6686551e68f7e8a663f8918c56d307b1:

[1.5.x] Fixed #12346 -- Added a note on how to validate InlineFormSets.

Thanks johnsmith for the suggestion.

Backport of 181f63c22d from master

Note: See TracTickets for help on using tickets.
Back to Top