A formset with no forms does not call self.clean() when self.is_valid() is called.

[tomevans222]

Test case:

from django import forms
from django.forms.formsets import BaseFormSet, formset_factory

class EmptyFsetWontValidate(BaseFormSet):
  def clean(self):
    raise forms.ValidationError, "Clean method called"

class SimpleForm(forms.Form):
  name = forms.CharField()

EmptyFsetWontValidateFormset = formset_factory(SimpleForm, extra=0, formset=EmptyFsetWontValidate)
formset = EmptyFsetWontValidateFormset({'form-INITIAL_FORMS':'0', 'form-TOTAL_FORMS':'0'})
formset2 = EmptyFsetWontValidateFormset({'form-INITIAL_FORMS':'0', 'form-TOTAL_FORMS':'1', 'form-0-name':'bah' })

# will return True
formset.is_valid()
# will return False
formset2.is_valid()
# But examine formset.errors...
formset.errors
# and now is_valid() will return False
formset.is_valid()

Test case is pretty straightforward. Trivial patch is attached.

[Jeremy Dunck]

This patch still needs tests, no matter how trivial the test case might be.

[David Novakovic]

Attaching updated patch that includes unit tests.

[Mark Lavin]

This patch works for me as on [13738] and looks ready for check in.

[Andrew Godwin]

(In [15158]) Fixed #12295 -- Issue had already been fixed, but added test. Thanks tomevans222 and dpn.

[Andrew Godwin]

(In [15159]) Fixed #12295 -- Issue had already been fixed, but added test. Thanks tomevans222 and dpn.