Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1229 closed defect (fixed)

[patch] magic-removal: date-based generic views should all support allow_empty

Reported by: nick@… Owned by: Jacob
Component: Generic views Version: magic-removal
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


It would seem logical for all date-based generic views to support an allow_empty argument; however, it appears that only archive_index and archive_day support it. This patch, against magic-removal rev 1958, adds allow_empty to archive_year and archive_month.

I fixed this basically by copying the appropriate logic from archive_index and archive_day to the other two views. Cursory testing with archive_month suggests it works, but I may well have overlooked something...

Attachments (1)

date_based.diff (2.4 KB) - added by nick@… 12 years ago.
Fixes date-based generic views to universally support allow_empty

Download all attachments as: .zip

Change History (2)

Changed 12 years ago by nick@…

Attachment: date_based.diff added

Fixes date-based generic views to universally support allow_empty

comment:1 Changed 12 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [2337]) Fixed #1229 -- Added allow_empty argument to archive_year and archive_month date-based generic views

Note: See TracTickets for help on using tickets.
Back to Top