Opened 15 years ago

Closed 15 years ago

Last modified 13 years ago

#12282 closed (fixed)

Admin Actions: No Way to Select All

Reported by: Paul Smith Owned by: Jannis Leidel
Component: contrib.admin Version: dev
Severity: Keywords: admin actions change-list
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:How to create a pull request

Description

Admin actions are only performed on items that have been selected in the change list. Users can only perform actions on items that actually appear on the page - items that do not appear in the list because of pagination can't be selected for actions. The Admin does a useful sanity check, and does not put a "Show all" link on the change list when the number of items is above a sane threshold (defined by MAX_SHOW_ALL_ALLOWED, which defaults to 200).

Filters help, and it's possible to raise the MAX_SHOW_ALL_ALLOWED value, but it's still a common - and valid - case that the user may want to perform an action on a set of items larger than a practical MAX_SHOW_ALL_ALLOWED value. And it's tedious to go through multiple pages of items performing actions on each page.

I propose adding something like what happens in GMail. When you've selected all the items on a page, a new link appears that says, "All 50 items on this page are selected. <link>Select all</link> 439 items in Whatever".

Change History (14)

comment:1 by Alex Gaynor, 15 years ago

Component: Contrib appsdjango.contrib.admin

This is related to #10615.

comment:2 by Paul Smith, 15 years ago

Owner: changed from nobody to Paul Smith
Status: newassigned

comment:3 by Paul Smith, 15 years ago

This should:

  • List the number of items selected on this page (merge in work from #10625)
  • Allow user to select all items (across pagination)
  • Paginator should respect "select all" so that all items are still selected when you go to the next page
  • When Go is pressed, action should be applied to all items that match currently applied filters

comment:4 by Martin Mahner, 15 years ago

I worked on this while fixing #10615. I have a working solution which has some edge bugs and needs proper testing. Attached is a screenshot.

by Martin Mahner, 15 years ago

Attachment: select-all.png added

comment:5 by Martin Mahner, 15 years ago

blinkylights; any problems when I reassign the ticket to me? I don't know what your work status is on this, my current patch is available on http://github.com/bartTC/django/tree/tickets/10615-acrosspages. Maybe it's worth to share ideas.

by Jannis Leidel, 15 years ago

Attachment: select-across.mp4 added

Current version

by Jannis Leidel, 15 years ago

Attachment: admin-selectacross.2.diff added

Featuring less brain farts

by Jannis Leidel, 15 years ago

Attachment: admin-selectacross.3.diff added

Even better now. Only needs through testing with the usual suspects (IE etc)

comment:6 by Jannis Leidel, 15 years ago

Has patch: set
milestone: 1.2
Needs documentation: set
Owner: changed from Paul Smith to Jannis Leidel
Status: assignednew
Triage Stage: UnreviewedAccepted
Version: 1.1SVN

comment:7 by Jannis Leidel, 15 years ago

Correction, the latest updates are here: http://github.com/jezdez/django/tree/admin-ui-combined

comment:8 by Jannis Leidel, 15 years ago

Resolution: fixed
Status: newclosed

(In [12298]) Fixed #12282 - When paginated allow selecting all items in the admin changlist.

Thanks to Martin Mahner, Rob Hudson and Zain Memon for providing inital patches and guidance.

comment:9 by Jacob, 13 years ago

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top