Opened 7 years ago

Closed 7 years ago

#12251 closed (fixed)

QuerySet.in_bulk() should accept a set()

Reported by: Johannes Dollinger Owned by: nobody
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by Alex Gaynor)

--- django/db/models/query.py	(revision 11751)
+++ django/db/models/query.py	(working copy)
@@ -356,7 +356,7 @@
         """
         assert self.query.can_filter(), \
                 "Cannot use 'limit' or 'offset' with in_bulk"
-        assert isinstance(id_list, (tuple, list)), \
+        assert isinstance(id_list, (tuple, list, set, frozenset)), \
                 "in_bulk() must be provided with a list of IDs."
         if not id_list:
             return {}

Attachments (1)

12251.queryset_in_bulk_set.diff (1.1 KB) - added by Johannes Dollinger 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Johannes Dollinger

comment:1 Changed 7 years ago by anonymous

Component: UncategorizedDatabase layer (models, ORM)
Has patch: set
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:2 Changed 7 years ago by Alex Gaynor

Description: modified (diff)
Triage Stage: UnreviewedReady for checkin
Version: 1.1SVN

comment:3 Changed 7 years ago by Luke Plant

Resolution: fixed
Status: newclosed

(In [11915]) Fixed #12251 - QuerySet.in_bulk() should accept set/frozenset

Thanks to emulbreh for patch.

Note: See TracTickets for help on using tickets.
Back to Top