Opened 7 years ago

Last modified 10 months ago

#12246 new Cleanup/optimization

contrib.admin's JavaScript functions should be namespaced

Reported by: italomaia Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


Some methods clash with some frameworks. addEvent is used in mootools and django-admin scripts.

Possible solution

# from FunFactor, IRC - mootools
var django = {}; django.addEvent = function(...);

Change History (5)

comment:1 Changed 6 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Agreed, although this should probably be done as part of a wholesale cleanup of the pieces of admin JS that aren't using jQuery.

comment:2 Changed 5 years ago by mattmcc

  • Severity set to Normal
  • Type set to Bug

comment:3 Changed 4 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:4 Changed 4 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:5 Changed 10 months ago by timgraham

  • Summary changed from Django-admin methods should be wraped in a django object to contrib.admin's JavaScript functions should be namespaced
  • Type changed from Bug to Cleanup/optimization
  • Version changed from 1.1 to master
Note: See TracTickets for help on using tickets.
Back to Top