Opened 15 years ago
Last modified 9 years ago
#12246 new Cleanup/optimization
contrib.admin's JavaScript functions should be namespaced
Reported by: | italomaia | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Pull Requests: | How to create a pull request | ||
Description ¶
Some methods clash with some frameworks. addEvent is used in mootools and django-admin scripts.
Possible solution
# from FunFactor, IRC - mootools
var django = {}; django.addEvent = function(...);
According to the ticket's flags, the next step(s) to move this issue forward are:
- To provide a patch by sending a pull request. Claim the ticket when you start working so that someone else doesn't duplicate effort. Before sending a pull request, review your work against the patch review checklist. Check the "Has patch" flag on the ticket after sending a pull request and include a link to the pull request in the ticket comment when making that update. The usual format is:
[https://github.com/django/django/pull/#### PR]
.
Change History (5)
comment:1 by , 15 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 14 years ago
Severity: | → Normal |
---|---|
Type: | → Bug |
comment:5 by , 9 years ago
Summary: | Django-admin methods should be wraped in a django object → contrib.admin's JavaScript functions should be namespaced |
---|---|
Type: | Bug → Cleanup/optimization |
Version: | 1.1 → master |
Note:
See TracTickets
for help on using tickets.
Agreed, although this should probably be done as part of a wholesale cleanup of the pieces of admin JS that aren't using jQuery.