Opened 7 years ago

Last modified 12 months ago

#12246 new Cleanup/optimization

contrib.admin's JavaScript functions should be namespaced

Reported by: italomaia Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Some methods clash with some frameworks. addEvent is used in mootools and django-admin scripts.

Possible solution

# from FunFactor, IRC - mootools
var django = {}; django.addEvent = function(...);

Change History (5)

comment:1 Changed 7 years ago by Russell Keith-Magee

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

Agreed, although this should probably be done as part of a wholesale cleanup of the pieces of admin JS that aren't using jQuery.

comment:2 Changed 5 years ago by Matt McClanahan

Severity: Normal
Type: Bug

comment:3 Changed 5 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:4 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:5 Changed 12 months ago by Tim Graham

Summary: Django-admin methods should be wraped in a django objectcontrib.admin's JavaScript functions should be namespaced
Type: BugCleanup/optimization
Version: 1.1master
Note: See TracTickets for help on using tickets.
Back to Top