Code

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#12217 closed (fixed)

FlatpageFallbackMiddleware means view middleware is not applied

Reported by: carljm Owned by: nobody
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

If flatpages are installed according to the docs (that is, using FlatpageFallbackMiddleware), any view middleware installed will not affect flatpages (because the flatpage view is not called in the usual fashion via URLconf).

It's not clear to me that this is a bug (it's perfectly logical once you realize what's happening), but it certainly can be a cause of confusing bugs ("why is this middleware I just installed not working on certain parts of my site?").

Perhaps it's just something to note in the flatpages docs? I'll put together a patch if someone can confirm that's the best solution here.

Attachments (0)

Change History (5)

comment:1 Changed 4 years ago by russellm

  • Component changed from Contrib apps to Documentation
  • milestone set to 1.2
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Yeah - I think this is a documentation issue.

comment:2 Changed 4 years ago by russellm

  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 4 years ago by ubernostrum

  • Resolution set to fixed
  • Status changed from new to closed

(In [12671]) Fixed #12217: Documented the fact that serving flatpages from the flatpage middleware does not apply view middleware methods.

comment:4 Changed 4 years ago by ubernostrum

(In [12672]) [1.1.X] Fixed #12217: Documented the fact that serving flatpages from the flatpage middleware does not apply view middleware methods. Backport of [12671] from trunk.

comment:5 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.