Code

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#12189 closed (fixed)

Cache database backend should use rollback_unless_managed

Reported by: lakinwecker Owned by: nobody
Component: Core (Cache system) Version: 1.1
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In 1.1 and trunk I think it would be best if it used transaction.rollback_unless_managed() - as this causes an error when the code isn't under transaction management:

source:django/branches/releases/1.1.X/django/core/cache/backends/db.py#L68 and source:django/trunk/django/core/cache/backends/db.py#L68

Attachments (0)

Change History (5)

comment:1 Changed 4 years ago by russellm

  • Has patch set
  • milestone set to 1.2
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 4 years ago by russellm

  • Component changed from Uncategorized to Cache system

comment:3 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [12409]) Fixed #12189 -- Corrected rollback behavior in database cache backend. Thanks to Lakin Wecker for the report.

comment:4 Changed 4 years ago by russellm

(In [12413]) [1.1.X] Fixed #12189 -- Corrected rollback behavior in database cache backend. Thanks to Lakin Wecker for the report.

Backport of r12409 from trunk.

comment:5 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.