Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#12189 closed (fixed)

Cache database backend should use rollback_unless_managed

Reported by: Lakin Wecker Owned by: nobody
Component: Core (Cache system) Version: 1.1
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In 1.1 and trunk I think it would be best if it used transaction.rollback_unless_managed() - as this causes an error when the code isn't under transaction management:

source:django/branches/releases/1.1.X/django/core/cache/backends/db.py#L68 and source:django/trunk/django/core/cache/backends/db.py#L68

Change History (5)

comment:1 by Russell Keith-Magee, 14 years ago

Has patch: set
milestone: → 1.2
Triage Stage: Unreviewed → Accepted

comment:2 by Russell Keith-Magee, 14 years ago

Component: Uncategorized → Cache system

comment:3 by Russell Keith-Magee, 14 years ago

Resolution: → fixed
Status: new → closed

(In [12409]) Fixed #12189 -- Corrected rollback behavior in database cache backend. Thanks to Lakin Wecker for the report.

comment:4 by Russell Keith-Magee, 14 years ago

(In [12413]) [1.1.X] Fixed #12189 -- Corrected rollback behavior in database cache backend. Thanks to Lakin Wecker for the report.

Backport of r12409 from trunk.

comment:5 by Jacob, 13 years ago

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top