Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#12189 closed (fixed)

Cache database backend should use rollback_unless_managed

Reported by: Lakin Wecker Owned by: nobody
Component: Core (Cache system) Version: 1.1
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In 1.1 and trunk I think it would be best if it used transaction.rollback_unless_managed() - as this causes an error when the code isn't under transaction management:

source:django/branches/releases/1.1.X/django/core/cache/backends/db.py#L68 and source:django/trunk/django/core/cache/backends/db.py#L68

Change History (5)

comment:1 Changed 7 years ago by Russell Keith-Magee

Has patch: set
milestone: 1.2
Triage Stage: UnreviewedAccepted

comment:2 Changed 7 years ago by Russell Keith-Magee

Component: UncategorizedCache system

comment:3 Changed 7 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [12409]) Fixed #12189 -- Corrected rollback behavior in database cache backend. Thanks to Lakin Wecker for the report.

comment:4 Changed 7 years ago by Russell Keith-Magee

(In [12413]) [1.1.X] Fixed #12189 -- Corrected rollback behavior in database cache backend. Thanks to Lakin Wecker for the report.

Backport of r12409 from trunk.

comment:5 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top