Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#12164 closed (fixed)

Remove Python 2.3 imports

Reported by: Tim Graham Owned by: nobody
Component: Core (Other) Version: dev
Severity: Keywords:
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Since Python 2.3 is no longer supported beginning with Django 1.2, we can remove these imports on trunk.

Attachments (2)

12164.diff (38.0 KB ) - added by Tim Graham 14 years ago.
13062.diff (142.3 KB ) - added by Claude Paroz 14 years ago.
Patch that passes tests

Download all attachments as: .zip

Change History (9)

by Tim Graham, 14 years ago

Attachment: 12164.diff added

comment:1 by Collin Anderson, 14 years ago

We still need to import decimal in 2.4, we just don't need to the one in django.utils.

comment:2 by Alex Gaynor, 14 years ago

Triage Stage: UnreviewedAccepted

In past we've said we didn't want to do this because it makes backporting patches harder, I don't think that's accurate. So we should do this (and delete the decimal backport).

comment:3 by Claude Paroz, 14 years ago

I've refreshed the patch on current trunk. I also deleted the django/utils/_decimal.py file.

by Claude Paroz, 14 years ago

Attachment: 13062.diff added

Patch that passes tests

comment:4 by Russell Keith-Magee, 14 years ago

milestone: 1.2
Triage Stage: AcceptedDesign decision needed

We need to get a design decision on this before 1.2RC

comment:5 by Alex Gaynor, 14 years ago

Russ, Karen and I discussed this the other day and I think the consensus was that it was probably a good idea, as we've had accidental backports that caused Python 2.3 breakages. Doing it in one fell-swoop avoids that possibility.

comment:6 by Russell Keith-Magee, 14 years ago

Resolution: fixed
Status: newclosed

(In [13094]) Fixed #12164 -- Removed the Python 2.3 compatibility imports and workarounds. Thanks to timo and claudep for the patch.

comment:7 by Jacob, 12 years ago

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top