Code

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#12164 closed (fixed)

Remove Python 2.3 imports

Reported by: timo Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Since Python 2.3 is no longer supported beginning with Django 1.2, we can remove these imports on trunk.

Attachments (2)

12164.diff (38.0 KB) - added by timo 4 years ago.
13062.diff (142.3 KB) - added by claudep 4 years ago.
Patch that passes tests

Download all attachments as: .zip

Change History (9)

Changed 4 years ago by timo

comment:1 Changed 4 years ago by CollinAnderson

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

We still need to import decimal in 2.4, we just don't need to the one in django.utils.

comment:2 Changed 4 years ago by Alex

  • Triage Stage changed from Unreviewed to Accepted

In past we've said we didn't want to do this because it makes backporting patches harder, I don't think that's accurate. So we should do this (and delete the decimal backport).

comment:3 Changed 4 years ago by claudep

I've refreshed the patch on current trunk. I also deleted the django/utils/_decimal.py file.

Changed 4 years ago by claudep

Patch that passes tests

comment:4 Changed 4 years ago by russellm

  • milestone set to 1.2
  • Triage Stage changed from Accepted to Design decision needed

We need to get a design decision on this before 1.2RC

comment:5 Changed 4 years ago by Alex

Russ, Karen and I discussed this the other day and I think the consensus was that it was probably a good idea, as we've had accidental backports that caused Python 2.3 breakages. Doing it in one fell-swoop avoids that possibility.

comment:6 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [13094]) Fixed #12164 -- Removed the Python 2.3 compatibility imports and workarounds. Thanks to timo and claudep for the patch.

comment:7 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.