Code

Opened 4 years ago

Closed 4 years ago

#12106 closed (fixed)

FileFields ignore initial data when required=False

Reported by: etianen Owned by: nobody
Component: Forms Version: 1.1
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: UI/UX:

Description

If you create a form containing a FileField where required=False, then the field will ignore any initial value passed in.

from django import forms
from django.core.files import File

class MyForm(forms.Form):
    file_field = forms.FileField(required=False)

test_file = File(open("test.txt"))

form = MyForm(data={}, initial={"file_field": test_file})

form.is_valid()  # Force form validation.

print form.cleaned_data["file_field"]  # prints None

Given that an initial value was supplied, the cleaned_data should now contain the initial value. However, it contains None, as the initial value has been silently discarded.

Attachments (1)

patch.txt (540 bytes) - added by etianen 4 years ago.

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by etianen

comment:1 Changed 4 years ago by russellm

  • Needs documentation unset
  • Needs tests set
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 4 years ago by etianen

Looking over the Django source code, it would appear that this issue has been fixed. Many thanks!

Would it be okay to mark this as fixed?

comment:3 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

If you believe an issue has been resolved, then mark it closed. Trac is completely open for all to modify for exactly this reason. If it turns out you are mistaken, the original reporter can always reopen. In this case, you *are* the original reporter, so that's not likely to happen :-)

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.