Code

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#12097 closed (fixed)

ModelChoiceField does not document required queryset parameter properly

Reported by: ptone Owned by: JasonYosinski
Component: Documentation Version: 1.1
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

http://docs.djangoproject.com/en/dev/ref/forms/fields/#modelchoicefield

The reference to ModelChoiceField.queryset comes before the section on ModelChoiceField and it should come after - also it should be more explicit that queryset is a required parameter

Attachments (1)

ModelChoiceField_doc.diff (3.6 KB) - added by JasonYosinski 4 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 4 years ago by russellm

  • milestone set to 1.2
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 4 years ago by JasonYosinski

  • Owner changed from nobody to JasonYosinski
  • Status changed from new to assigned

comment:3 Changed 4 years ago by JasonYosinski

  • Has patch set

Patch submitted and ready for review.

Changed 4 years ago by JasonYosinski

comment:4 follow-up: Changed 4 years ago by anonymous

  • Triage Stage changed from Accepted to Ready for checkin

on re-reading the original version it is technically complete. However I think the order in the included patch is clearer.

comment:5 in reply to: ↑ 4 Changed 4 years ago by ptone

Replying to anonymous:

on re-reading the original version it is technically complete. However I think the order in the included patch is clearer.

Sorry - this comment was by me - the original reporter of this item - didn't see I was no longer logged in

comment:6 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [12712]) Fixed #12097 -- Cleaned up the documentation for ModelChoiceField and MultipleModelChoiceField. Thanks to JasonYosinski for the patch.

comment:7 Changed 4 years ago by russellm

(In [12715]) [1.1.X] Fixed #12097 -- Cleaned up the documentation for ModelChoiceField and MultipleModelChoiceField. Thanks to JasonYosinski for the patch.

Backport of r12712 from trunk.

comment:8 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.