Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#12097 closed (fixed)

ModelChoiceField does not document required queryset parameter properly

Reported by: Preston Holmes Owned by: Jason Yosinski
Component: Documentation Version: 1.1
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

http://docs.djangoproject.com/en/dev/ref/forms/fields/#modelchoicefield

The reference to ModelChoiceField.queryset comes before the section on ModelChoiceField and it should come after - also it should be more explicit that queryset is a required parameter

Attachments (1)

ModelChoiceField_doc.diff (3.6 KB) - added by Jason Yosinski 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by Russell Keith-Magee

milestone: 1.2
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 7 years ago by Jason Yosinski

Owner: changed from nobody to Jason Yosinski
Status: newassigned

comment:3 Changed 7 years ago by Jason Yosinski

Has patch: set

Patch submitted and ready for review.

Changed 7 years ago by Jason Yosinski

Attachment: ModelChoiceField_doc.diff added

comment:4 Changed 7 years ago by anonymous

Triage Stage: AcceptedReady for checkin

on re-reading the original version it is technically complete. However I think the order in the included patch is clearer.

comment:5 in reply to:  4 Changed 7 years ago by Preston Holmes

Replying to anonymous:

on re-reading the original version it is technically complete. However I think the order in the included patch is clearer.

Sorry - this comment was by me - the original reporter of this item - didn't see I was no longer logged in

comment:6 Changed 7 years ago by Russell Keith-Magee

Resolution: fixed
Status: assignedclosed

(In [12712]) Fixed #12097 -- Cleaned up the documentation for ModelChoiceField and MultipleModelChoiceField. Thanks to JasonYosinski for the patch.

comment:7 Changed 7 years ago by Russell Keith-Magee

(In [12715]) [1.1.X] Fixed #12097 -- Cleaned up the documentation for ModelChoiceField and MultipleModelChoiceField. Thanks to JasonYosinski for the patch.

Backport of r12712 from trunk.

comment:8 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top