#12097 closed (fixed)
ModelChoiceField does not document required queryset parameter properly
| Reported by: | Preston Holmes | Owned by: | Jason Yosinski |
|---|---|---|---|
| Component: | Documentation | Version: | 1.1 |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | UI/UX: |
Description
http://docs.djangoproject.com/en/dev/ref/forms/fields/#modelchoicefield
The reference to ModelChoiceField.queryset comes before the section on ModelChoiceField and it should come after - also it should be more explicit that queryset is a required parameter
Attachments (1)
Change History (9)
comment:1 Changed 7 years ago by
| milestone: | → 1.2 |
|---|---|
| Needs documentation: | unset |
| Needs tests: | unset |
| Patch needs improvement: | unset |
| Triage Stage: | Unreviewed → Accepted |
comment:2 Changed 7 years ago by
| Owner: | changed from nobody to Jason Yosinski |
|---|---|
| Status: | new → assigned |
comment:3 Changed 7 years ago by
| Has patch: | set |
|---|
Changed 7 years ago by
| Attachment: | ModelChoiceField_doc.diff added |
|---|
comment:4 follow-up: 5 Changed 7 years ago by
| Triage Stage: | Accepted → Ready for checkin |
|---|
on re-reading the original version it is technically complete. However I think the order in the included patch is clearer.
comment:5 Changed 7 years ago by
Replying to anonymous:
on re-reading the original version it is technically complete. However I think the order in the included patch is clearer.
Sorry - this comment was by me - the original reporter of this item - didn't see I was no longer logged in
comment:6 Changed 7 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:7 Changed 7 years ago by
Note: See
TracTickets for help on using
tickets.
Patch submitted and ready for review.