Opened 7 years ago

Closed 5 years ago

#12073 closed New feature (fixed)

AdminDateWidget and AdminTimeWidget not passing though additional attrs

Reported by: elliss Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords: widgets date time calendar
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Karen Tracey)

Suggest a change to allow additional user-defined attributes to be passed though. currently they're passed in but not though:

CURRENT:

class AdminDateWidget(forms.TextInput):
    class Media:
        js = (settings.ADMIN_MEDIA_PREFIX + "js/calendar.js",
              settings.ADMIN_MEDIA_PREFIX + "js/admin/DateTimeShortcuts.js")

    def __init__(self, attrs={}):
        super(AdminDateWidget, self).__init__(attrs={'class': 'vDateField', 'size': '10'})

class AdminTimeWidget(forms.TextInput):
    class Media:
        js = (settings.ADMIN_MEDIA_PREFIX + "js/calendar.js",
              settings.ADMIN_MEDIA_PREFIX + "js/admin/DateTimeShortcuts.js")

    def __init__(self, attrs={}):
        super(AdminTimeWidget, self).__init__(attrs={'class': 'vTimeField', 'size': '8'})

SUGGESTED:

class AdminDateWidget(forms.TextInput):
    class Media:
        js = (settings.ADMIN_MEDIA_PREFIX + "js/calendar.js",
              settings.ADMIN_MEDIA_PREFIX + "js/admin/DateTimeShortcuts.js")

    def __init__(self, attrs={}):
        attrs.update({'class': 'vDateField', 'size': '10'})
        super(AdminDateWidget, self).__init__(attrs=attrs)

class AdminTimeWidget(forms.TextInput):
    class Media:
        js = (settings.ADMIN_MEDIA_PREFIX + "js/calendar.js",
              settings.ADMIN_MEDIA_PREFIX + "js/admin/DateTimeShortcuts.js")

    def __init__(self, attrs={}):
        attrs.update({'class': 'vTimeField', 'size': '8'})
        super(AdminTimeWidget, self).__init__(attrs=attrs)

Attachments (1)

12073.diff (3.1 KB) - added by Koen Biermans 5 years ago.
patch with test for 12073

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by Karen Tracey

Description: modified (diff)

Fixed formatting. Please use WikiFormatting and the preview button.

comment:2 Changed 7 years ago by Russell Keith-Magee

milestone: 1.2
Triage Stage: UnreviewedAccepted

comment:3 Changed 7 years ago by James Bennett

milestone: 1.2

1.2 is feature-frozen, moving this feature request off the milestone.

comment:4 Changed 6 years ago by anonymous

attrs.update() is maybe too simple - that still wouldn't allow to change (or just add) a CSS class or change the size

comment:5 Changed 6 years ago by Julien Phalip

Easy pickings: unset
Has patch: set
Needs tests: set
Patch needs improvement: set
Severity: Normal
Type: New feature

Changed 5 years ago by Koen Biermans

Attachment: 12073.diff added

patch with test for 12073

comment:6 Changed 5 years ago by Koen Biermans

Easy pickings: set
Needs tests: unset
Patch needs improvement: unset
UI/UX: unset
Version: 1.0SVN

The attached patch allows passing attrs into AdminDateWidget and AdminTimeWidget. Added a test too.

comment:7 Changed 5 years ago by Julien Phalip

Resolution: fixed
Status: newclosed

In [17125]:

Fixed #12073 -- Made AdminDateWidget and AdminTimeWidget consider user-supplied attrs. Thanks to elliss for the report and to koenb for the patch.

Note: See TracTickets for help on using tickets.
Back to Top