Show generic relation on deleted objects

[rui.coelho@…]

Generic foreign key relations are deleted but not shown in confirmation page.

[anonymous]

added callback to edit confirmation message, merged with ticket #6191

[anonymous]

add related object to callback

[Alex Gaynor]

This patch uses a mutable default value which is bad practice and will cause it to fail when called more than once.

[anonymous]

add delete confirmation for top (deleted) obj

[Alex Gaynor]

This patch a) still has the mutable default value, and b) includes django.contrib.contenttypes in the ORM, we want to work to reducing that dependency, not increasing it.

[anonymous]

Replying to Alex:

This patch a) still has the mutable default value, and b) includes django.contrib.contenttypes in the ORM, we want to work to reducing that dependency, not increasing it.

a) Which mutable default value are you talking about, is it "objs_seen", if yes, you suggest to start this value with what and why ??

b) Humm, ok, i will see what i can do to avoid that. If you have a suggestion i would appreciate.

[anonymous]

syntax error fixed

[Carl Meyer]

Replying to Alex:

This patch a) still has the mutable default value, and b) includes django.contrib.contenttypes in the ORM, we want to work to reducing that dependency, not increasing it.

Unfortunately the ORM already depends on contrib.contenttypes in at least one other place: source:/django/trunk/django/db/models/sql/subqueries.py#29 - agree that we should be looking to get rid of that, not add more dependency.

This patch would be eclipsed by the patch on #6191, which replaces the admin's related-objects-finding with delegation to the actual ORM code. I'm looking at what it would take to fix this as part of #6191.

[Russell Keith-Magee]

Closing as a duplicate of #6191.