Code

Opened 5 years ago

Last modified 3 years ago

#11941 new Bug

FilteredMultipleSelect does not render help text

Reported by: techieone Owned by: nobody
Component: Forms Version: 1.1
Severity: Normal Keywords:
Cc: tyrion Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

The FilteredMultipleSelect in the admin widgets suite can be imported and used in other forms. However, it does not render any helptext whether that helptext was defined on the model field or the form field.

Attachments (1)

patch.diff (1.1 KB) - added by tyrion 4 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 4 years ago by tyrion

The help text is not displayed because SelectFilter2.js removes all paragraphs that "get in the way".

        // Remove <p class="info">, because it just gets in the way.
        var ps = from_box.parentNode.getElementsByTagName('p');
        for (var i=0; i<ps.length; i++) {
            from_box.parentNode.removeChild(ps[i]);
        }

I think the problem may be solved by reinserting these <p> after the widget has been created.
I made a patch for the js that works for me, but the paragraphs are displayed at the right of the widget and not at the bottom as I think they should.
Unfortunately I am not able to fix the css ...

Here's a screenshot, http://img337.imageshack.us/img337/5863/schermataadddummymodeld.png

Changed 4 years ago by tyrion

comment:3 Changed 4 years ago by tyrion

  • Has patch set

comment:4 Changed 4 years ago by tyrion

  • Cc tyrion added

comment:5 Changed 3 years ago by julien

  • Severity set to Normal
  • Type set to Bug

comment:6 Changed 3 years ago by patchhammer

  • Easy pickings unset
  • Patch needs improvement set

patch.diff fails to apply cleanly on to trunk

comment:7 Changed 2 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as new
The owner will be changed from nobody to anonymous. Next status will be 'assigned'
as The resolution will be set. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.