EmailMessage.to accepts tuple or list, but EmailMessage.recipients() fails if it's a tuple

[Ben Davis]

Basically, if you set "to" to a tuple, the recipients() method fails because it's concatenating self.to + self.bcc, and bcc by default is []. So if self.to is a tuple, you get an exception. The simple fix is:

Index: django/core/mail.py
===================================================================
--- django/core/mail.py (revision 11587)
+++ django/core/mail.py (working copy)
@@ -255,7 +255,7 @@
         Returns a list of all recipients of the email (includes direct
         addressees as well as Bcc entries).
         """
-        return self.to + self.bcc
+        return list(self.to) + list(self.bcc)

     def send(self, fail_silently=False):
         """Sends the email message."""

[Ben Davis]

Updated for 1.2-beta

[Claude Paroz]

Test that problem has been resolved

[Claude Paroz]

I think that the problem has been fixed by other changesets. However, I still attach a test case with recipients as tuples, as I think it was still untested.

[Jannis Leidel]

In [16133]:

Fixed #11928 -- Added test for tuple to list conversion during mail message initialization added in r11709. Thanks, Claude Paroz.