ORDER BY in aggregate subqueries is not necessary and might cause problems on some SQL servers

[egenix_viktor]

Some SQL servers, like MS SQL 2005 does not allow ORDER BY in subqueries without a TOP modifier. (It might apply to other database servers as well.) It is also suboptimal to use ORDER BY in the subquery of an aggregate SELECT, since it does not affect the result.

It might be better to just clear ordering in the subquery in this case. I suggest adding the following line in the BaseQuery.get_aggregation method before the query.add_subquery(obj) call:

obj.clear_ordering(True)

Patch against the db\models\sql\query.py file of the 1.1 release version has been attached.

[egenix_viktor]

Patch against db/models/sql/query.py (Django 1.1, release version)

[Russell Keith-Magee]

Not critical for 1.2

[Jacob]

Milestone 1.3 deleted

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[Anssi Kääriäinen]

There is a clear_ordering clause in get_aggregation(), line 356 of django/db/models/sql/query.py

[Anssi Kääriäinen]

The above isn't correct, the clear_ordering is applied to the outer query, not to the inner query. So, back to "accepted".

[Anssi Kääriäinen <akaariai@…>]

In 7bc57a6d71dd4d00bb09cfa67be547591fd759ce:

Fixed #11881 -- removed junk from aggregation subqueries

There were clauses that weren't needed in the subqueries. These were
ORDER BY, SELECT FOR UPDATE and related selections.