Moderation doesn't work with comments extended from BaseCommentAbstractModel

[HM]

CommentFlag has a hardcoded foreign key to django.contrib.comments.models.Comment and thus the moderation-bits of django.contrib.comments cannot be used when inheriting directly from BaseCommentAbstractModel.

Either this should be mentioned in the documentation or CommentFlag should have a

    import comments
    ...
    comment   = models.ForeignKey(comments.get_model(), verbose_name=_('comment'), related_name="flags")

instead of

    comment   = models.ForeignKey(Comment, verbose_name=_('comment'), related_name="flags")

[Thejaswi Puthraya]

git-patch against the latest checkout

[Thejaswi Puthraya]

The patch uploaded by me doesn't work because it goes into a cyclical import and fails.
Sorry for uploading that patch without verifying. Underestimated this issue...

[Jannis Leidel]

Any progress on this?

[Thejaswi Puthraya]

git patch against the latest checkout

[Thejaswi Puthraya]

The latest patch works but it does late module loading ie the imports are called within an if...else statement. This is discouraged in PEP-8 and django's contributing guide but is the only way it can be solved. Every other method I could think of results in a recursive ImportError.

[Jannis Leidel]

Hm, I can't really think of an alternative, too. But a test of this behaviour would be good.

[Thejaswi Puthraya]

git patch against the latest checkout with the required tests

[James Bennett]

1.2 is feature-frozen, moving this feature request off the milestone.

[Jannis Leidel]

The last patch didn't run me: ​https://gist.github.com/f6284636f9edd130bd96

[Jannis Leidel]

Jesus, of course the patch didn't run me, but it didn't run *for* me, too :)

[Thejaswi Puthraya]

Jannis, This patch works but the settings.py should have the COMMENTS_APP attribute set before the tests are run. The toggling of the COMMENTS_APP attribute in the CustomCommentTest class (present under comment_tests/tests/app_api_tests.py) does not help, because syncdb would've already taken place as soon as the test started and in the process, the evaluation of get_model function in the CommentFlag model.

The problem of setting the COMMENTS_APP to the custom comments explicitly before the tests are run will cause all the default comment tests to fail, unless there are some changes made the CommentTestCase class' setUp method.

What do you suggest? Do we require a test for this or modifying the comment tests?

[Thejaswi Puthraya]

As per a discussion with Jannis and Russell, this ticket needs to wait till LazyForeignKey or some equivalent.

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[Jacob]

django.contrib.comments has been deprecated and is no longer supported, so I'm closing this ticket. We're encouraging users to transition to a custom solution, or to a hosted solution like Disqus.

The code itself has moved to ​https://github.com/django/django-contrib-comments; if you want to keep using it, you could move this bug over there.