Opened 6 years ago

Closed 5 years ago

Last modified 4 years ago

#11852 closed (fixed)

html template password_reset_email.html has badly translatable string

Reported by: pihentagy Owned by: nobody
Component: contrib.admin Version: 1.1
Severity: Keywords: i18n, l10n
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

django/contrib/admin/templates/registration/password_reset_email.html contains ugly trans tags:

{% trans "You're receiving this e-mail because you requested a password reset" %}
{% blocktrans %}for your user account at {{ site_name }}{% endblocktrans %}.

Maybe it worth considering using one big blocktrans for the whole letter (with aliases), as you should not reuse small pieces from that letter.

Attachments (1)

11852_trans_string.diff (823 bytes) - added by julien 5 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 years ago by pihentagy

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Summary changed from password_reset_email has badly translatable string to html template password_reset_email.html has badly translatable string

comment:2 Changed 6 years ago by russellm

  • Triage Stage changed from Unreviewed to Accepted

Changed 5 years ago by julien

comment:3 Changed 5 years ago by julien

  • Has patch set
  • milestone set to 1.3
  • Triage Stage changed from Accepted to Ready for checkin

I presume the patch is trivial enough to promote to RFC before 1.3's string freeze.

comment:4 Changed 5 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

In [15606]:

Fixed #11852 -- Ensure that a long string in the password reset email can be translated. Thanks to pihentagy for the report.

comment:5 Changed 4 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top