Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#11849 closed (fixed)

use_tls initialization bug in django.core.mail.SMTPConnection

Reported by: aromano Owned by: nobody
Component: Core (Mail) Version: 1.1
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Hi all,
I have created this new ticket to make you aware of a bug on django.core.mail.SMTPConnection at constructor level, where use_tls is not initialized properly. Indeed, in case you decide to initialize a SMTPConnection instance with use_tls=False, and settings.EMAIL_USE_TLS defined as True, then the actual value that is set is not False (as explicitly defined at construction level, and as we expect), but True instead. I have created a patch for this, which is attached to this ticket. I am aware of this bug's existance since Django 1.0, and it is still present under SVN release.

Attachments (1)

patch.diff (638 bytes) - added by aromano 6 years ago.
simple patch for the aforementioned bug

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by aromano

simple patch for the aforementioned bug

comment:1 Changed 6 years ago by aromano

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Version set to 1.1

comment:2 Changed 6 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [11714]) Fixed #11849 -- Corrected handling of use_tls in the SMTP mail handler. Thanks to aromano for the report.

comment:3 Changed 6 years ago by russellm

(In [11715]) [1.1.X] Fixed #11849 -- Corrected handling of use_tls in the SMTP mail handler. Thanks to aromano for the report.

Backport of r11714 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top