Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#11843 closed (fixed)

MultipleHiddenInput outputs invalid HTML (inputs all get the same ID)

Reported by: Chris Beaven Owned by: Chris Beaven
Component: Forms Version: 1.1
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Yep, that's the gist of it. CheckboxSelectMultiple already has a fix for this, but not MultipleHiddenInput.

Attachments (2)

11843.diff (1.2 KB) - added by Chris Beaven 7 years ago.
11843.2.diff (3.3 KB) - added by Chris Beaven 7 years ago.
with tests

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by Chris Beaven

Attachment: 11843.diff added

comment:1 Changed 7 years ago by Chris Beaven

Needs documentation: unset
Needs tests: set
Patch needs improvement: unset
Status: newassigned
Triage Stage: UnreviewedAccepted

Changed 7 years ago by Chris Beaven

Attachment: 11843.2.diff added

with tests

comment:2 Changed 7 years ago by Chris Beaven

Needs tests: unset
Triage Stage: AcceptedReady for checkin

comment:3 Changed 7 years ago by Chris Beaven

milestone: 1.2

comment:4 Changed 7 years ago by Jannis Leidel

Resolution: fixed
Status: assignedclosed

(In [12151]) Fixed #11843 - Give MultipleHiddenInput different IDs. Thanks Chris Beaven.

comment:5 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top