Opened 7 years ago

Closed 6 years ago

#11804 closed (fixed)

Filterspec fails to remove __isnull when __exact passed

Reported by: marcob Owned by: nobody
Component: contrib.admin Version: 1.1
Severity: Keywords:
Cc: marcoberi@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by Russell Keith-Magee)

I have a link for my users that open a changelist page with a user__id__isnull=True. That changelist has also a list filter on my users. When a user is chosen, the filter __isnull is not removed.
I wrote this (working) patch modifying get_query_string function in admin/views/main.py.
I remove __isnull when __exact is passed (in remove or in new_params)

Attachments (1)

remove-filter-isnull.diff (704 bytes) - added by marcob 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by marcob

Attachment: remove-filter-isnull.diff added

comment:1 Changed 7 years ago by marcob

Cc: marcoberi@… added
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:2 Changed 7 years ago by Russell Keith-Magee

Component: django-admin.pydjango.contrib.admin
Description: modified (diff)
Has patch: set
Needs tests: set

comment:3 Changed 7 years ago by Russell Keith-Magee

Triage Stage: UnreviewedAccepted

comment:4 Changed 6 years ago by Julien Phalip

Resolution: fixed
Status: newclosed

This was another symptom of the bug in #8528, which has been resolved by the corresponding changeset [15649]. All is working fine now.

Note: See TracTickets for help on using tickets.
Back to Top