Opened 7 years ago

Closed 6 years ago

Last modified 3 years ago

#11700 closed Uncategorized (fixed)

actions and list_editables in popups problematic

Reported by: sehmaschine@… Owned by: Simon Meers
Component: contrib.admin Version: master
Severity: Normal Keywords: design_ux, sprintdec2010
Cc: Gonzalo Saavedra, sehmaschine@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

IMHO, actions should not be visible in popups. list_editable should also not work, because

  • in popups, one is able to select and add elements. changing an element is not possible. so, why is it possible to change elements on the level of a change-list?
  • moreover, delete_selected_confirmation doesn´t handle popups correctly.

Attachments (1)

11700.diff (4.3 KB) - added by Simon Meers 6 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 7 years ago by Russell Keith-Magee

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Resolution: invalid
Status: newclosed

If you have a design opinion, take it up on django-dev. As fair warning - abstract suggestions aren't going to get much traction unless you're willing to back them up with code.

comment:2 Changed 7 years ago by Russell Keith-Magee

Resolution: invalid
Status: closedreopened
Triage Stage: UnreviewedDesign decision needed
Version: 1.1

In light of the recent discussions regarding the state of Django's design, I'm reopening and marking this DDN.

comment:3 Changed 7 years ago by Russell Keith-Magee

Keywords: design_ux added

comment:4 Changed 6 years ago by mrts

A tip for those who need to hide actions in popups:

class FooAdmin(admin.ModelAdmin):
    def get_actions(self, request):
        actions = super(ShowInListAdmin, self).get_actions(request)
        if request.REQUEST.has_key('pop'): # hide actions in popups
            actions.clear()
        return actions

comment:5 Changed 6 years ago by Simon Meers

Has patch: set
milestone: 1.3
Owner: changed from nobody to Simon Meers
Status: reopenednew
Triage Stage: Design decision neededAccepted
Version: SVN

Changed 6 years ago by Simon Meers

Attachment: 11700.diff added

comment:6 Changed 6 years ago by Gonzalo Saavedra

Cc: Gonzalo Saavedra added

comment:7 Changed 6 years ago by Simon Meers

Keywords: sprint_dec_2010 added

comment:8 Changed 6 years ago by Simon Meers

Keywords: sprintdec2010 added; sprint_dec_2010 removed

comment:9 Changed 6 years ago by Brodie Rao

Triage Stage: AcceptedReady for checkin

comment:10 Changed 6 years ago by anonymous

Cc: sehmaschine@… added

comment:11 Changed 6 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

(In [15129]) Fixed #11700 -- Stopped admin actions and list_editable fields to show up in popups. Thanks to Simon Meers for the initial patch.

comment:12 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

comment:13 Changed 3 years ago by anonymous

Easy pickings: unset
Severity: Normal
Type: Uncategorized
UI/UX: unset
Note: See TracTickets for help on using tickets.
Back to Top