Opened 6 years ago

Closed 4 years ago

Last modified 2 years ago

#11700 closed Uncategorized (fixed)

actions and list_editables in popups problematic

Reported by: sehmaschine@… Owned by: DrMeers
Component: contrib.admin Version: master
Severity: Normal Keywords: design_ux, sprintdec2010
Cc: gonz, sehmaschine@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

IMHO, actions should not be visible in popups. list_editable should also not work, because

  • in popups, one is able to select and add elements. changing an element is not possible. so, why is it possible to change elements on the level of a change-list?
  • moreover, delete_selected_confirmation doesn´t handle popups correctly.

Attachments (1)

11700.diff (4.3 KB) - added by DrMeers 5 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 5 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to invalid
  • Status changed from new to closed

If you have a design opinion, take it up on django-dev. As fair warning - abstract suggestions aren't going to get much traction unless you're willing to back them up with code.

comment:2 Changed 5 years ago by russellm

  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Triage Stage changed from Unreviewed to Design decision needed
  • Version 1.1 deleted

In light of the recent discussions regarding the state of Django's design, I'm reopening and marking this DDN.

comment:3 Changed 5 years ago by russellm

  • Keywords design_ux added

comment:4 Changed 5 years ago by mrts

A tip for those who need to hide actions in popups:

class FooAdmin(admin.ModelAdmin):
    def get_actions(self, request):
        actions = super(ShowInListAdmin, self).get_actions(request)
        if request.REQUEST.has_key('pop'): # hide actions in popups
            actions.clear()
        return actions

comment:5 Changed 5 years ago by DrMeers

  • Has patch set
  • milestone set to 1.3
  • Owner changed from nobody to DrMeers
  • Status changed from reopened to new
  • Triage Stage changed from Design decision needed to Accepted
  • Version set to SVN

Changed 5 years ago by DrMeers

comment:6 Changed 5 years ago by gonz

  • Cc gonz added

comment:7 Changed 4 years ago by DrMeers

  • Keywords sprint_dec_2010 added

comment:8 Changed 4 years ago by DrMeers

  • Keywords sprintdec2010 added; sprint_dec_2010 removed

comment:9 Changed 4 years ago by brodie

  • Triage Stage changed from Accepted to Ready for checkin

comment:10 Changed 4 years ago by anonymous

  • Cc sehmaschine@… added

comment:11 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

(In [15129]) Fixed #11700 -- Stopped admin actions and list_editable fields to show up in popups. Thanks to Simon Meers for the initial patch.

comment:12 Changed 4 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

comment:13 Changed 2 years ago by anonymous

  • Easy pickings unset
  • Severity set to Normal
  • Type set to Uncategorized
  • UI/UX unset
Note: See TracTickets for help on using tickets.
Back to Top