Can't remove prepopulated fields from fieldset in ModelAdmin

[leanmeandonothingmachine]

I'd like to propose that when the prepopulated fields argument that is passed to the AdminForm helper in BaseModelAdmin is generated by a method that takes the request object. That would give you ability to use the get_fieldsets overide to filter out prepopulated fields and then use this new override to alter the prepopulated fields to match what you did in get_fieldsets. See attached patch for my implementation.

[leanmeandonothingmachine]

Sorry that should be in ModelAdmin not BaseModelAdmin

[leanmeandonothingmachine]

I updated the patch so it applies against trunk.

[leanmeandonothingmachine]

Updated the patch again. If there is anything wrong with this that is holding it up please lmk, i'd be happy to improve it.

[Julien Phalip]

That's a useful feature, but unfortunately it is too late for 1.3.

[leanmeandonothingmachine]

I updated the patch to include tests and documentation. I also added inline support based on the way get_readonly_fields works. Can this be considered for 1.3? If it really is too late then change it back to 1.4, it would be nice though to have this get some attention.

[Julien Phalip]

This is a good patch, thanks for your great work. There's no guarantee that it can make it in 1.3 as this is essentially a new feature and we're now in beta stage. So we'll see ;)

[Russell Keith-Magee]

Agreed that this looks like a good idea, but it's definitely a new feature, not a bug fix, so it can't be added to 1.3 at this point.

[leanmeandonothingmachine]

Ok, on the other hand it could be considered a fix for the bug in #13618

[defaultwombat]

This is definitly a fix for #13618 too.

Additionally it solves a problem when trying to manually fix the #13618 issue by changeing the prepopulated_fields e.g. in the change_view.
As this is a dictionary shared over all instances of the Adminmodel, after altering it you lost the prepopulating feature until server refresh.

[Jannis Leidel]

In [16069]:

Fixed #11639, #13618 -- Added get_prepopulated_fields method to ModelAdmin and InlineModelAdmin to be able to handle prepopulated fields on a case-by-case basis. Thanks, leanmeandonothingmachine.

[Jacob]

Milestone 1.4 deleted

[hcarvalhoalves@…]

Any reason why this ticket didn't entered 1.3.1? It's still set for 1.3-beta. I would like to see this checked in for 1.3.2, let me know if I can help with tests or documentation. It's pretty annoying to have the get_fieldsets hook available but see it fail because of prepopulated_fields , and then rewrite almost half of the ModelAdmin to fix it.

[Ramiro Morales]

Replying to hcarvalhoalves@…:

Any reason why this ticket didn't entered 1.3.1?

It's because bug fixes like this are no longer backported to the stable branch - it will not be in the next 1.3.X release. See ​https://docs.djangoproject.com/en/dev/internals/release-process/#supported-versions -- We changed our backporting policy for the maintenance period post 1.3.

It's still set for 1.3-beta

I was reported as present in 1.3 beta (Version field of this ticket) but it was targetted to be fixed in 1.4 (Milestone field, since then removed from our Trac installation)

I would like to see this checked in for 1.3.2, let me know if I can help with tests or documentation. It's pretty annoying to have the get_fieldsets hook available but see it fail because of prepopulated_fields , and then rewrite almost half of the ModelAdmin to fix it.

You can always port the changes committed to fix this ticket (or a subset of them) to a local copy of the 1.3.X branch and use that.