Code

Opened 5 years ago

Closed 5 years ago

#11611 closed (invalid)

can't place two comment forms in one template. Because "prefix" attribute is not supported in __init__ of this form

Reported by: oduvan Owned by: nobody
Component: contrib.comments Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I just don't get. Why you design CommentSecurityForm.init so strange?

Attachments (2)

prefix_for_comment.diff (962 bytes) - added by oduvan 5 years ago.
prefix_for_comment.2.diff (1.6 KB) - added by oduvan 5 years ago.

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by oduvan

Changed 5 years ago by oduvan

comment:1 Changed 5 years ago by oduvan

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

no, this fix will be better. It fix security check to.

comment:2 Changed 5 years ago by russellm

  • Resolution set to invalid
  • Status changed from new to closed

I'm sorry - if you want us to take a problem report seriously, you have to take the reporting process seriously. This report:

  • Asks a question in the ticket title
  • Expresses incredulity, but doesn't actually explain the problem in the body
  • Provides a patch that doesn't contain any explanation or documentation.

I'm not going to play 20 questions while I try to work out what this ticket and patch is trying to achieve. If you care to provide a detailed description of the underlying problem and the approach you have taken to solve it, feel free to reopen the ticket.

comment:3 Changed 5 years ago by oduvan

  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Summary changed from How can I add prifix attribute, to CommentForm? to can't place two comment forms in one template. Because "prefix" attribute is not supported in __init__ of this form

I'm sorry. But this bug, was so unexpected for me, that's why report was so short.

comment:4 Changed 5 years ago by oduvan

and I'm sorry again. How can I fix description of ticket? Or I must open one more ticket?

comment:5 Changed 5 years ago by Alex

If you could just clearly describe what the bug is, what the expectation is and what actually happens in a c omment that would be good.

comment:6 Changed 5 years ago by russellm

  • Resolution set to invalid
  • Status changed from reopened to closed

@oduvan - the "bug" may be "unexpected", but you haven't described what the problem _is_. The report is so short that it doesn't actually contain any information. *PLEASE* - I'm begging you - EXPLAIN THE PROBLEM.

Closing again until we have an actual problem description.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.