Opened 15 years ago
Last modified 13 years ago
#11595 closed Cleanup/optimization
Fixture validation errors should report their data — at Version 5
Reported by: | freyley | Owned by: | Raúl Cumplido |
---|---|---|---|
Component: | Core (Serialization) | Version: | 1.0 |
Severity: | Normal | Keywords: | easy-pickings |
Cc: | Anand Kumria, Peter van Kampen | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description (last modified by )
For example, here's what django/db/models/fields/__init__.py
has for lines 341-348:
def to_python(self, value): if value is None: return value try: return int(value) except (TypeError, ValueError): raise exceptions.ValidationError(_("This value must be an integer."))
Changing line 348 to:
_("(%s) must be an integer." % value))
means that when you convert a text field to a joined object, you know which one's broken where. (Other places in that file do the same thing)
Change History (5)
comment:1 by , 15 years ago
Has patch: | unset |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 14 years ago
Description: | modified (diff) |
---|---|
Keywords: | easy-pickings added |
Severity: | → Normal |
Type: | → Cleanup/optimization |
comment:3 by , 14 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:5 by , 14 years ago
Description: | modified (diff) |
---|
Note:
See TracTickets
for help on using tickets.
It seems the code is changed since the bug was reported. Now the code has dictionaries with default_error_messages. Example for lines 865-857:
And in the Exception it has the next, lines 884-890:
Should we change the code to:
I am new and that's why I taked an easy_pickings one. But I want to have your ok to prepare my first patch.