Opened 7 years ago

Closed 6 years ago

Last modified 5 years ago

#11594 closed (fixed)

Inaccurate docstring for WhereNode.add()

Reported by: Jim Garrison Owned by: Derek Willis
Component: Documentation Version: 1.1-beta
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

r9700 changed the interface for WhereNode.add(), but it did not update the function's docstring to reflect the change.

The docstring currently says:

        """
        Add a node to the where-tree. If the data is a list or tuple, it is
        expected to be of the form (alias, col_name, field_obj, lookup_type,
        value), which is then slightly munged before being stored (to avoid
        storing any reference to field objects). Otherwise, the 'data' is
        stored unchanged and can be anything with an 'as_sql()' method.
        """

As of r9700, if data is a list or tuple, it is actually expected to be of the form (obj, lookup_type, value), where obj is a Constraint object.

Attachments (1)

11594.diff (1.4 KB) - added by Derek Willis 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by Alex Gaynor

Triage Stage: UnreviewedAccepted

comment:2 Changed 6 years ago by Derek Willis

Owner: changed from nobody to Derek Willis
Status: newassigned

Changed 6 years ago by Derek Willis

Attachment: 11594.diff added

comment:3 Changed 6 years ago by Derek Willis

Has patch: set
milestone: 1.3
Triage Stage: AcceptedReady for checkin

comment:4 Changed 6 years ago by Derek Willis

Component: Database layer (models, ORM)Documentation

comment:5 Changed 6 years ago by Luke Plant

Resolution: fixed
Status: assignedclosed

(In [13843]) Fixed #11594 - Inaccurate docstring for WhereNode.add()

Thanks to garrison for report, dwillis for patch

comment:6 Changed 6 years ago by Luke Plant

(In [13844]) [1.2.X] Fixed #11594 - Inaccurate docstring for WhereNode.add()

Thanks to garrison for report, dwillis for patch

Backport of [13843] from trunk

comment:7 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top