Opened 9 years ago

Closed 6 years ago

#11537 closed Bug (invalid)

localflavor for india's state choices are not tuples

Reported by: zbyte64 Owned by: lars
Component: contrib.localflavor Version: master
Severity: Normal Keywords: localflavorsplit
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no



The STATE_CHOICES should be an iterable of tuples to be consistent with the rest of localflavor.

Attachments (1)

11537.diff (10.6 KB) - added by lars 9 years ago.
Patch cleans up the STATE_CHOICES and adds a test

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by Alex Gaynor

Triage Stage: UnreviewedAccepted

Changed 9 years ago by lars

Attachment: 11537.diff added

Patch cleans up the STATE_CHOICES and adds a test

comment:2 Changed 9 years ago by lars

Has patch: set
Owner: changed from nobody to lars
Status: newassigned

This should fix this ticket and at least bring it in line with the current status of the other localflavors.

The state Uttaranchal has been renamed to Uttarakhand in 2007. With this change the license plate has changed from UA to UK. As people might rely on UA as a key in their databases I didn't change this one. The ISO code is yet another one (UL). The documentation says "Input is normalized to the standard two-letter vehicle registration abbreviation for the given state or territory." so this is not really 100% true at the moment. But as I'm not from India and I don't know how important this change is I left it as it was.

comment:3 Changed 7 years ago by Julien Phalip

Severity: Normal
Type: Bug

comment:4 Changed 7 years ago by Julien Phalip

Patch needs improvement: set

Thanks a lot for this. Could you please rewrite the tests using unittest before we can check this in?

comment:5 Changed 6 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:6 Changed 6 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:7 Changed 6 years ago by Aymeric Augustin

Keywords: localflavorsplit added
Resolution: invalid
Status: assignedclosed

django.contrib.localflavor is now deprecated — see

A repository was created for each localflavor at (Replace with the country code.)

If you're still interested in this ticket, could you create a pull request on that repository?

Sorry for not resolving this issue earlier, and thanks for your input!

Note: See TracTickets for help on using tickets.
Back to Top