loaddata doesn't return the proper exit code on error

[Justin Lilly]

When loaddata errors, it doesn't return a proper error code. Instead, it just returns.

[Justin Lilly]

Patch which uses sys.exit(1) instead of return.

[Michael Newman]

This looks like a valid point. There are several other places in that command that should do the same thing, i.e. ​http://code.djangoproject.com/browser/django/trunk/django/core/management/commands/loaddata.py#L141, ​http://code.djangoproject.com/browser/django/trunk/django/core/management/commands/loaddata.py#L181

Why print the errors and not raise them in these cases, let python return the error code?

[Justin Lilly]

I think the reason for printing the error messages and not returning exceptions is that we want to run the rollbacks. This could be fixed with a finally statement, but requires mucking with the code structure more. This seems like the simplest things that works.

I've also added another patch which corrects the other places where an error is printed, but not returning the right status code.

[Jyrki Pulliainen]

...or you could raise django.core.management.CommandError and let it raise through the whole stack. It would make the manage.py to exit with exit status 1.

[Julien Phalip]

Dupe of #10200.