Code

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#11473 closed (duplicate)

TEMPLATE_STRING_IF_INVALID breaks admin template

Reported by: Leo Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Repro:

  1. set TEMPLATE_STRING_IF_INVALID in settings to 'FOOBAR'
  2. view any object list page in the admin
  3. notice the checkbox on the left of the items is misaligned
  4. view source to see the following:
    <table cellspacing="0">
    <thead>
    
    <tr>
    <thFOOBAR>
    

I suspect this is a pretty easy fix, I just couldn't figure out where to make it. The templates are pretty abstract/convoluted :-/

Attachments (0)

Change History (3)

comment:1 Changed 5 years ago by ramiro

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to duplicate
  • Status changed from new to closed

This is known issue (#3579 tracks it). I don't dare to call it a bug because the behavior is documented (see the "For debug purposes only!" note at http://docs.djangoproject.com/en/dev/ref/templates/api/#how-invalid-variables-are-handled)

comment:2 Changed 5 years ago by Leo

Thanks ramiro, totally missed #3579. You're right, the behavior is documented, but it still may be a good idea to change the admin templates to handle it better. Obviously, pretty low pri.

comment:3 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.