Opened 7 years ago

Closed 7 years ago

#11455 closed (wontfix)

Rename misleadingly named sql_create_table_suffix function

Reported by: Dennis Kaarsemaker Owned by: nobody
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


While investigating a way to implement a new feature I wanted, I came across the sql_create_table_suffix function in django.db.backends.creation and subclasses. This function has a misleading name as it is only used when creating the test database. Attached patch renames the function to say what it does.

Attachments (1)

rename-sql-table-creation-suffix.diff (2.2 KB) - added by Dennis Kaarsemaker 7 years ago.

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by Dennis Kaarsemaker

comment:1 Changed 7 years ago by Dennis Kaarsemaker

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

Trac doesn't want to render the patch apparently. The download link works though.

comment:2 Changed 7 years ago by Russell Keith-Magee

Resolution: wontfix
Status: newclosed

It might be a bad name, but we don't gain anything signficant by renaming it, and renaming it would break any code using the existing name.

Note: See TracTickets for help on using tickets.
Back to Top