Opened 15 years ago
Closed 15 years ago
#11455 closed (wontfix)
Rename misleadingly named sql_create_table_suffix function
Reported by: | Dennis Kaarsemaker | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
While investigating a way to implement a new feature I wanted, I came across the sql_create_table_suffix function in django.db.backends.creation and subclasses. This function has a misleading name as it is only used when creating the test database. Attached patch renames the function to say what it does.
Attachments (1)
Change History (3)
by , 15 years ago
Attachment: | rename-sql-table-creation-suffix.diff added |
---|
comment:1 by , 15 years ago
comment:2 by , 15 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
It might be a bad name, but we don't gain anything signficant by renaming it, and renaming it would break any code using the existing name.
Note:
See TracTickets
for help on using tickets.
Trac doesn't want to render the patch apparently. The download link works though.