Opened 15 years ago

Closed 13 years ago

Last modified 13 years ago

#11447 closed (fixed)

foreign keys need class nowrap for td in changelist

Reported by: patrick@… Owned by: nobody
Component: contrib.admin Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

in admin_list.py, line 184 insert:
row_class = ' class="nowrap"'

otherwise, the add_another-button is in the next line if the screen is too small.

Attachments (1)

11447_fk_nowrap.diff (844 bytes ) - added by Julien Phalip 13 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by anonymous, 15 years ago

Version: 1.0SVN

comment:2 by Alex Gaynor, 15 years ago

Triage Stage: UnreviewedAccepted

by Julien Phalip, 13 years ago

Attachment: 11447_fk_nowrap.diff added

comment:3 by Julien Phalip, 13 years ago

Triage Stage: AcceptedReady for checkin

This seems trivial enough to directly promote to RFC. I don't think this needs tests.

comment:4 by Russell Keith-Magee, 13 years ago

Triage Stage: Ready for checkinAccepted

For future reference -- this might not need tests, but it certainly needs an clearer explanation. I eventually worked out that this was referring to the wrapping behavior of a changelist when list_editable is in use, but it's vastly preferable to not have to do that sort of detective work.

comment:5 by Russell Keith-Magee, 13 years ago

Triage Stage: AcceptedReady for checkin

comment:6 by Russell Keith-Magee, 13 years ago

Also - you may not need to add a test, but you should *run* the tests. Patch as provided breaks two tests regressiontests/admin_changelist.

comment:7 by Russell Keith-Magee, 13 years ago

Resolution: fixed
Status: newclosed

In [15656]:

Fixed #11447 -- Ensured that ForeignKey widgets in a list-editable admin changelist won't wrap split the widget. Thanks to patrick@… for the report, and Julien Phalip for the patch.

comment:8 by Russell Keith-Magee, 13 years ago

In [15658]:

[1.2.X] Fixed #11447 -- Ensured that ForeignKey widgets in a list-editable admin changelist won't wrap split the widget. Thanks to patrick@… for the report, and Julien Phalip for the patch.

Backport of r15656 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top