Code

Opened 5 years ago

Closed 3 years ago

Last modified 3 years ago

#11447 closed (fixed)

foreign keys need class nowrap for td in changelist

Reported by: patrick@… Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

in admin_list.py, line 184 insert:
row_class = ' class="nowrap"'

otherwise, the add_another-button is in the next line if the screen is too small.

Attachments (1)

11447_fk_nowrap.diff (844 bytes) - added by julien 3 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 5 years ago by anonymous

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Version changed from 1.0 to SVN

comment:2 Changed 5 years ago by Alex

  • Triage Stage changed from Unreviewed to Accepted

Changed 3 years ago by julien

comment:3 Changed 3 years ago by julien

  • Triage Stage changed from Accepted to Ready for checkin

This seems trivial enough to directly promote to RFC. I don't think this needs tests.

comment:4 Changed 3 years ago by russellm

  • Triage Stage changed from Ready for checkin to Accepted

For future reference -- this might not need tests, but it certainly needs an clearer explanation. I eventually worked out that this was referring to the wrapping behavior of a changelist when list_editable is in use, but it's vastly preferable to not have to do that sort of detective work.

comment:5 Changed 3 years ago by russellm

  • Triage Stage changed from Accepted to Ready for checkin

comment:6 Changed 3 years ago by russellm

Also - you may not need to add a test, but you should *run* the tests. Patch as provided breaks two tests regressiontests/admin_changelist.

comment:7 Changed 3 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

In [15656]:

Fixed #11447 -- Ensured that ForeignKey widgets in a list-editable admin changelist won't wrap split the widget. Thanks to patrick@… for the report, and Julien Phalip for the patch.

comment:8 Changed 3 years ago by russellm

In [15658]:

[1.2.X] Fixed #11447 -- Ensured that ForeignKey widgets in a list-editable admin changelist won't wrap split the widget. Thanks to patrick@… for the report, and Julien Phalip for the patch.

Backport of r15656 from trunk.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.