Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#1141 closed defect (fixed)

[patch] Fix various unit test failures in r1799

Reported by: freakboy@… Owned by: Adrian Holovaty
Component: Core (Other) Version:
Severity: minor Keywords: magic-removal unit test failure
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


As of r1799, there are 6 unit tests failing in the magic-removal branch.

3 faillures were introduced by r1794, when a __repr__ method was added to MultiValueDict.

3 failures were introduced by r1797, when a debug print statement was left in the commit for do_html2python.

This patch resolves these 6 failures.

Attachments (1)

unit_tests.r1799.patch (2.0 KB ) - added by freakboy@… 18 years ago.
Patch to resolve unit test failures in r1799

Download all attachments as: .zip

Change History (3)

by freakboy@…, 18 years ago

Attachment: unit_tests.r1799.patch added

Patch to resolve unit test failures in r1799

comment:1 by freakboy@…, 18 years ago

In addition to the patch described here, line 463 of source:django/branches/magic-removal/django/db/models/ contains another debug print statment.

Although it doesn't currently cause a test failure, this is probably only because there is no test coverage of manipulator collections. Removing this line as well is probably a good idea.

comment:2 by Adrian Holovaty, 18 years ago

Resolution: fixed
Status: newclosed

(In [1801]) magic-removal: Fixed #1141 -- Fixed unit-test failures in [1799]. Thanks, Russ

Note: See TracTickets for help on using tickets.
Back to Top