Code

Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#1141 closed defect (fixed)

[patch] Fix various unit test failures in r1799

Reported by: freakboy@… Owned by: adrian
Component: Core (Other) Version:
Severity: minor Keywords: magic-removal unit test failure
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

As of r1799, there are 6 unit tests failing in the magic-removal branch.

3 faillures were introduced by r1794, when a __repr__ method was added to MultiValueDict.

3 failures were introduced by r1797, when a debug print statement was left in the commit for do_html2python.

This patch resolves these 6 failures.

Attachments (1)

unit_tests.r1799.patch (2.0 KB) - added by freakboy@… 9 years ago.
Patch to resolve unit test failures in r1799

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by freakboy@…

Patch to resolve unit test failures in r1799

comment:1 Changed 9 years ago by freakboy@…

In addition to the patch described here, line 463 of source:django/branches/magic-removal/django/db/models/manipulators.py#1799 contains another debug print statment.

Although it doesn't currently cause a test failure, this is probably only because there is no test coverage of manipulator collections. Removing this line as well is probably a good idea.

comment:2 Changed 9 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [1801]) magic-removal: Fixed #1141 -- Fixed unit-test failures in [1799]. Thanks, Russ

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.