Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#11404 closed New feature (fixed)

add has_changed() method to formsets

Reported by: anonymous Owned by: nobody
Component: Forms Version: 1.0
Severity: Normal Keywords: formset
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

both formsets and forms have .is_valid()
but only forms have .has_changed()
it would be nice if formsets had it too

Attachments (2)

formset-has-changed.diff (620 bytes) - added by Dennis Kaarsemaker 7 years ago.
formset-has-changed-2.diff (3.9 KB) - added by Michel Sabchuk 5 years ago.
Patch updated to Django 1.3 with tests and docs.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by anonymous

Component: UncategorizedForms
Keywords: formset added
Triage Stage: UnreviewedSomeday/Maybe

Changed 7 years ago by Dennis Kaarsemaker

Attachment: formset-has-changed.diff added

comment:2 Changed 7 years ago by Dennis Kaarsemaker

Has patch: set
Triage Stage: Someday/MaybeUnreviewed

Patch attached.

comment:3 Changed 7 years ago by Alex Gaynor

Triage Stage: UnreviewedAccepted

comment:4 Changed 6 years ago by Matthias Kestenholz

Needs documentation: set
Needs tests: set

comment:5 Changed 6 years ago by Julien Phalip

Severity: Normal
Type: New feature

Changed 5 years ago by Michel Sabchuk

Attachment: formset-has-changed-2.diff added

Patch updated to Django 1.3 with tests and docs.

comment:6 Changed 5 years ago by Mark Lavin

Easy pickings: unset
Needs documentation: unset
Needs tests: unset
Triage Stage: AcceptedReady for checkin
UI/UX: unset

The latest patch has tests and docs. It applies cleanly for me on the latest trunk and all the tests pass. This looks ready for check-in to me.

comment:7 Changed 5 years ago by Alex Gaynor

Resolution: fixed
Status: newclosed

In [16773]:

Fixed #11404. Added FormSet.has_changed, for consistancy with Form.has_changed. Thanks to michelts for the patch.

Note: See TracTickets for help on using tickets.
Back to Top