Code

Opened 5 years ago

Closed 3 years ago

Last modified 3 years ago

#11404 closed New feature (fixed)

add has_changed() method to formsets

Reported by: anonymous Owned by: nobody
Component: Forms Version: 1.0
Severity: Normal Keywords: formset
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

both formsets and forms have .is_valid()
but only forms have .has_changed()
it would be nice if formsets had it too

Attachments (2)

formset-has-changed.diff (620 bytes) - added by seveas 5 years ago.
formset-has-changed-2.diff (3.9 KB) - added by michelts 3 years ago.
Patch updated to Django 1.3 with tests and docs.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 5 years ago by anonymous

  • Component changed from Uncategorized to Forms
  • Keywords formset added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Someday/Maybe

Changed 5 years ago by seveas

comment:2 Changed 5 years ago by seveas

  • Has patch set
  • Triage Stage changed from Someday/Maybe to Unreviewed

Patch attached.

comment:3 Changed 5 years ago by Alex

  • Triage Stage changed from Unreviewed to Accepted

comment:4 Changed 3 years ago by mk

  • Needs documentation set
  • Needs tests set

comment:5 Changed 3 years ago by julien

  • Severity set to Normal
  • Type set to New feature

Changed 3 years ago by michelts

Patch updated to Django 1.3 with tests and docs.

comment:6 Changed 3 years ago by mlavin

  • Easy pickings unset
  • Needs documentation unset
  • Needs tests unset
  • Triage Stage changed from Accepted to Ready for checkin
  • UI/UX unset

The latest patch has tests and docs. It applies cleanly for me on the latest trunk and all the tests pass. This looks ready for check-in to me.

comment:7 Changed 3 years ago by Alex

  • Resolution set to fixed
  • Status changed from new to closed

In [16773]:

Fixed #11404. Added FormSet.has_changed, for consistancy with Form.has_changed. Thanks to michelts for the patch.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.