Opened 7 years ago

Closed 6 years ago

#11397 closed New feature (duplicate)

[New Feature In Admin] Added Edit-Icon in selection widget of ForeignKey and ManyToMany Fields(Relationship fields).

Reported by: Dharmesh Patel Owned by: Dharmesh [Patel
Component: contrib.admin Version: 1.1-beta
Severity: Normal Keywords: Edit Icon, edit selected item in selection widget
Cc: dvanliere@…, Dario Ocles Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Added a Edit-Icon to edit selected items in selection widget of ForeignKey and ManyToMany fields(Relationship fields) in admin interface.

Attachments (4)

add_edit_icon.diff (10.4 KB) - added by Dharmesh Patel 7 years ago.
SVN Diff File for add an Edit Icon in selection widget of Relationship fields like ForeignKey and ManyToMany Fields.
Screenshot-1.png (82.9 KB) - added by Dharmesh Patel 7 years ago.
In Admin interface Edit-Icon will see in selection widget of relation fields.
Screenshot-2.png (134.2 KB) - added by Dharmesh Patel 7 years ago.
By clicking on Edit-Icon edit page will open for selected item in selection widget.
add_edit_icon_r15922.diff (9.8 KB) - added by Dario Ocles 6 years ago.

Download all attachments as: .zip

Change History (14)

Changed 7 years ago by Dharmesh Patel

Attachment: add_edit_icon.diff added

SVN Diff File for add an Edit Icon in selection widget of Relationship fields like ForeignKey and ManyToMany Fields.

Changed 7 years ago by Dharmesh Patel

Attachment: Screenshot-1.png added

In Admin interface Edit-Icon will see in selection widget of relation fields.

Changed 7 years ago by Dharmesh Patel

Attachment: Screenshot-2.png added

By clicking on Edit-Icon edit page will open for selected item in selection widget.

comment:1 Changed 7 years ago by anonymous

milestone: 1.1

Why is this marked with milestone 1.1?
The release is already long overdue, and adding new features in the last straight line to the release is not a good idea...

comment:2 Changed 7 years ago by Dharmesh Patel

yes i selected Milestone as a 1.1 because i added this feature according to trunk-1.1-beta release nothing else.

comment:3 Changed 7 years ago by Alex Gaynor

Triage Stage: UnreviewedAccepted

comment:4 Changed 6 years ago by drdee

Cc: dvanliere@… added

What is the status of this ticket? Is this something for Django 1.3?

comment:5 Changed 6 years ago by Dharmesh Patel

that feature I already give to add in 1.1 beta version, but till I can not get any feedback from django community :(

comment:6 Changed 6 years ago by Dharmesh Patel

stage is just changed from 'unreviewed' to 'Accepted' by Alex only and then there is no feedback about it.

comment:7 Changed 6 years ago by Dario Ocles

Patch needs improvement: set

The patch doesn't work for me (SVN r15922)

Changed 6 years ago by Dario Ocles

Attachment: add_edit_icon_r15922.diff added

comment:8 Changed 6 years ago by Dario Ocles

Cc: Dario Ocles added
Patch needs improvement: unset

I took the patch and updated it to work with the latest trunk version (r15922)

comment:9 Changed 6 years ago by Simon Meers

Some time back I did quite a bit of work on a similar feature (1-3). For some reason this earlier ticket did not show up in searches at the time.

Please read the comment threads on tickets (1-2) and the discussion in (4), which explains why this hasn't been checked in yet.

I disagree with the approach of this ticket; a dynamic link beside a ForeignKey widget can lead to terrible UX, where the user is lead away to a different page thinking that the value in the select menu has been saved (or other modified fields). A static (and labelled) link to the last saved object is better IMHO.

(1) http://code.djangoproject.com/ticket/13163

(2) http://code.djangoproject.com/ticket/13165

(3) http://share.simonmeers.com/django_related_changelinks/

(4) http://groups.google.com/group/django-developers/browse_thread/thread/8812e50dfa1a3a8/450a7c7a81684cd3

comment:10 Changed 6 years ago by Julien Phalip

Resolution: duplicate
Severity: Normal
Status: newclosed
Type: New feature

I agree with Simon that the approach in #13163 and #13165 is preferable, so I'm closing as a dupe on that basis.

Note: See TracTickets for help on using tickets.
Back to Top