#11392 closed (fixed)
Spurious failures in test suite due to result set ordering
| Reported by: | nauch | Owned by: | nobody |
|---|---|---|---|
| Component: | Testing framework | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
A number of tests in the test suite occasionally fail due to order differences in the result set. The attached patch addresses the ones I have seen so far.
Attachments (1)
Change History (6)
by , 15 years ago
| Attachment: | result_set_ordering.diff added |
|---|
comment:1 by , 15 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 by , 15 years ago
As noted by Alex, the aggregation_regress change isn't required. The query should be returning a list of Book objects, and Book has an implied ordering by name. If you're getting different results here, either your backend isn't applying the implied ordering, or we have a deeper problem with query construction that hasn't been revealed by other tests to date.
comment:4 by , 15 years ago
Note:
See TracTickets
for help on using tickets.
The patch looks good, except for the last item. Django adds an ORDER BY clause to that query so I don't think the sorted operation is correct there. Also in the future please make diffs against the root of the source tree, instead of from inside the tests directory.