Code

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#11381 closed (fixed)

select_related over nullable ForeignKey using GeoQuerySet and GeoManager gives blank object rather than None

Reported by: bretthoerner Owned by: nobody
Component: GIS Version: 1.1-beta
Severity: Keywords: geodjango geo select_related geomanager
Cc: dgouldin@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: UI/UX:

Description

Sorry for the bad title... I can only explain this with an example,

from django.contrib.gis.db import models

class Author(models.Model):
    name = models.CharField(max_length=100)

class BookManager(models.GeoManager):
    def get_query_set(self):
        return super(BookManager, self).get_query_set().select_related('author')

class Book(models.Model):
    name = models.CharField(max_length=100)
    author = models.ForeignKey(Author, related_name="books", null=True, blank=True)

    objects = BookManager()
>>> Book.objects.create(name='Without Author')
<Book: Book object>

>>> b = Book.objects.get(name='Without Author')

>>> b.author
<Author: Author object>

>>> b.author.name

As you can see, rather than b.author being None, is it an "empty" Author object. This isn't the case when using non-GeoDjango.

What's even weirder is that this only happens when using the GeoManager. If you remove the manager and run the select_related yourself, the following happens,

>>> Book.objects.select_related('author').get(name='Without Author').author

It's None, rather than the "empty" Author from above.

Attachments (1)

11381.diff (501 bytes) - added by dgouldin 5 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 years ago by dgouldin

  • Cc dgouldin@… added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 5 years ago by dgouldin

Looks like the row being passed to django.db.models.query.get_cached_row is a list, not a tuple, which causes fields == (None,) * field_count to always fail. Thus obj is instantiated at times it should be set to None.

Changed 5 years ago by dgouldin

comment:3 Changed 5 years ago by dgouldin

  • Has patch set

comment:4 Changed 5 years ago by Alex

  • Needs tests set
  • Triage Stage changed from Unreviewed to Accepted

comment:5 Changed 5 years ago by jbronn

  • Resolution set to fixed
  • Status changed from new to closed

(In [11123]) Fixed #11381 -- GeoManager + select_related + nullable ForeignKey now works correctly. Thanks, bretthoerner for ticket and dgouldin for initial patch.

comment:6 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.