Opened 6 years ago

Closed 4 years ago

#11373 closed (fixed)

Change list layout breaks if no actions_form

Reported by: manuel_razzari Owned by:
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The documented ways to remove all admin actions (actions=None and disable_action) are causing minor but visible layout breakage on the change list page.

The template seems to be comparing against the wrong variables. Also, text-align is missing in the CSS override to restore the TH to its original layout.

Attaching screenshot and patch.

Attachments (3)

change_list.patch (661 bytes) - added by manuel_razzari 6 years ago.
Proposed patch
change_list.gif (14.4 KB) - added by manuel_razzari 6 years ago.
Screenshot reproducing the issue
patch-changelist.diff (1.8 KB) - added by mpaolini 6 years ago.
alternative patch

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by manuel_razzari

Proposed patch

Changed 6 years ago by manuel_razzari

Screenshot reproducing the issue

comment:1 Changed 6 years ago by ubernostrum

  • milestone 1.1 deleted
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Only extremely critical bugs are being accepted for the 1.1 milestone right now.

comment:2 Changed 6 years ago by Alex

  • Triage Stage changed from Unreviewed to Accepted

Changed 6 years ago by mpaolini

alternative patch

comment:3 Changed 6 years ago by mpaolini

I'm submitting an alternate patch based on the original.

I believe this one is cleaner 'cause all css code is kept in stylesheet no (extra <style> in change_list.html)

comment:4 Changed 6 years ago by jacob

  • Owner jacob deleted

comment:5 Changed 4 years ago by julien

  • Resolution set to fixed
  • Status changed from new to closed

I can't seem to be able to reproduce this, so I assume it has been fixed in a previous changeset. If you disagree, please reopen and provide a concrete code example that we can test.

Note: See TracTickets for help on using tickets.
Back to Top