Opened 6 years ago

Closed 6 years ago

#11357 closed (fixed)

contrib.admindocs ignores many-to-many relations

Reported by: ubernostrum Owned by: nobody
Component: Contrib apps Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

It's a one-line patch; needs to look at _meta.get_all_related_many_to_many_objects() when collecting related objects.

Attachments (3)

admindocs-m2m.diff (641 bytes) - added by ubernostrum 6 years ago.
admindocs-m2m-both-ways.diff (1.4 KB) - added by ubernostrum 6 years ago.
New patch; respects both sides of the m2m
admindocs-m2m-both-ways-2.patch (1.7 KB) - added by benspaulding 6 years ago.
Added <field>.count, and other consistency changes.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by ubernostrum

Changed 6 years ago by ubernostrum

New patch; respects both sides of the m2m

comment:1 Changed 6 years ago by benspaulding

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I have taken the admindocs-m2m-both-ways.diff patch and updated it so it is consistent with other relationships. <field>.count is now listed and the data type of <field>.all is changed to List.

However, I simply copied how it was done for the other relations — maybe there is a better/cleaner way of doing this, rather than repeating these parts.

Changed 6 years ago by benspaulding

Added <field>.count, and other consistency changes.

comment:2 Changed 6 years ago by Alex

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r11127

Note: See TracTickets for help on using tickets.
Back to Top