Bug with humanize and timezones

[aarond10]

Humanize's naturalday filter uses "date.today()" to determine relative dates. This is not valid if you pass it a datetime with the tzinfo field set. The following patch uses a datetime object as an intermediary to correct this behavior.

[aarond10]

Patch to humanize.py

[Russell Keith-Magee]

This is annoying, but it isn't critical for v1.1 at this late stage (it doesn't cause data loss, and there are viable workarounds).

Also, the patch needs tests in order to prove that it works.

[aarond10ster@…]

Very basic test cases:

from django.contrib.humanize.templatetags.humanize import naturalday
from datetime import datetime
from pytz import timezone

# Test without timezone (basically the same as existing code)

naturalday(datetime.now())

u'today'

# GMT+9

naturalday(datetime.now(timezone('Asia/Tokyo')))

u'today'

# GMT+2

naturalday(datetime.now(timezone('Europe/Rome')))

u'today'

# GMT+0

naturalday(datetime.now(timezone('UTC')))

u'today'

# GMT-4

naturalday(datetime.now(timezone('America/New_York')))

u'today'

[Sergio Oliveira]

Patch including some fixes (using svn diff)

[Sergio Oliveira]

Unit tests

[Sergio Oliveira]

Merging tests and patch

[Jannis Leidel]

In [16072]:

Fixed #11321 -- Handle timezones correctly in conjunction with naturalday filter. Thanks, aarond10 and seocam.

[Gerben Morsink]

To be honoust I still don't like the solution.

It means you have to create a custom Date object (that inherits from datetime.date), where you manually set the tzinfo attribute.

I think using timezone.get_current_timezone() would be much more convenient!

[Aymeric Augustin]

This ticket was closed 5 years ago, before Django gained support for timezones in version 1.4. The naturalday filter was refactored in that version.

Given that the landscape has changed significantly since this ticket was discussed, it would be best to open a new ticket and explain the problem you see in the current implementation.

That will make it more likely that someone will understand what you want to do and make it happen. Thanks!