Code

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11253 closed (fixed)

TestCase method docs should consistently use TestCase.methodName

Reported by: SmileyChris Owned by: nobody
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Currently we have:

TestCase.assertContains(response, text, count=None, status_code=200)
TestCase.assertNotContains(response, text, status_code=200)
assertFormError(response, form, field, errors)
assertTemplateUsed(response, template_name)
assertTemplateNotUsed(response, template_name)
assertRedirects(response, expected_url, status_code=302, target_status_code=200)

They're all TestCase methods so they should all be either with or without the TestCase. prefix (I say with)

Attachments (1)

11253.diff (2.2 KB) - added by SmileyChris 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by SmileyChris

comment:1 Changed 5 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 5 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [11051]) Fixed #11253 -- Normalized the way the docs refer to TestCase.assert* methods. Thanks to SmileyChris for the report and patch.

comment:3 Changed 5 years ago by russellm

(In [11063]) [1.0.X] Fixed #11253 -- Normalized the way the docs refer to TestCase.assert* methods. Thanks to SmileyChris for the report and patch.

Merge of r11051 from trunk.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.