Django do not serve static binary files (e.g. images) correctly

[hipertracker@…]

Django do not serve static binary files (e.g. images) correctly

Solution:

django-0.90-py2.4.egg\django\views\static.py line 52:

Change line 52 from:

return HttpResponse(open(fullpath, 'rb').read(), mimetype=mimetype)

to:

return HttpResponse(open(fullpath).read(), mimetype=mimetype)

[eugene@…]

Could you explain what's wrong with the currrent code (1 line)? What kind of effects do you see? What OS and Python version did you use? How do you solve the problem by removing 'rb'? I cannot reproduce the problem.

[rjwittams]

It sounds like they have uploaded an image in ASCII mode to their server, so this would end up undoing the damage. User error and should be closed if so....

[hipertracker@…]

django v0.9 has line return HttpResponse(open(fullpath).read(), mimetype=mimetype). I found in svn it was corrected. I made a mistake with message, It had to be:
Change line 52 from:
HttpResponse(open(fullpath).read(), mimetype=mimetype)
to
return HttpResponse(open(fullpath, 'rb').read(), mimetype=mimetype)

[Jacob]

This is fixed in trunk.