#11212 closed Cleanup/optimization (fixed)
Don't encode emails with base64/qp
Reported by: | phr | Owned by: | nobody |
---|---|---|---|
Component: | Core (Mail) | Version: | dev |
Severity: | Normal | Keywords: | send_mail |
Cc: | petr.hroudny@… | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
#3472 introduced a patch, which replaces base64 encoding with quoted-printable.
Anyway, there's even better way to do get rid of unnecessary encoding:
from email import Charset Charset.add_charset('utf-8',Charset.SHORTEST,None,'utf-8')
The above will set Content-Transfer-Encoding to 7bit or 8bit as needed - exactly as Mutt or Thunderbird do
and completely solve the problem even for non-latin characters.
Attachments (2)
Change History (20)
comment:1 by , 15 years ago
Cc: | added; removed |
---|
comment:2 by , 15 years ago
Needs tests: | set |
---|
comment:3 by , 15 years ago
I'm not quite sure what to test here. Only a single parameter needs to be changed
in file django/core/mail.py at line 23:
-Charset.add_charset('utf-8', Charset.SHORTEST, Charset.QP, 'utf-8') +Charset.add_charset('utf-8', Charset.SHORTEST, None, 'utf-8')
comment:4 by , 15 years ago
You need to update and add to the tests in tests/regressiontests/mail/tests.py, which fail with the above change. You should add tests that show what happens with 7bit and 8bit data.
comment:5 by , 15 years ago
Yes, sure those tests fail. They test for:
Content-Transfer-Encoding: quoted-printable
at multiple places, which after the proposed change will not pass.
If the input is pure ascii, that header will become:
Content-Transfer-Encoding: 7bit
If the input contains some accentuated character - e.g. 'áéí', there will be 8bit instead.
comment:6 by , 15 years ago
milestone: | → 1.2 |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:7 by , 15 years ago
Owner: | changed from | to
---|
by , 15 years ago
Attachment: | 0001-Ticket-11212-default-to-7bit-email.patch added |
---|
Patch with adjusted tests
comment:8 by , 15 years ago
Needs tests: | unset |
---|---|
Owner: | changed from | to
Patch needs improvement: | set |
I've included a patch that makes the tests pass, but as demonstrated by the patch this make us start generating email with "Content-Transfer-Encoding: 8bit
" when passing in Unicode strings as subject or content. I think that should be avoided, so I don't recommend this patch as is.
comment:9 by , 15 years ago
milestone: | 1.2 |
---|
1.2 is feature-frozen, moving this feature request off the milestone.
comment:10 by , 15 years ago
Replying to gisle:
I've included a patch that makes the tests pass, but as demonstrated by the patch this make us start generating email with "
Content-Transfer-Encoding: 8bit
" when passing in Unicode strings as subject or content. I think that should be avoided, so I don't recommend this patch as is.
The use of 8bit encoding is exactly the aim of this ticket, so the patch does the right thing IMHO.
Except for a few legacy paths, SMTP is mostly 8bit today - and where not, it's the MTA's role to downconvert to 7bit.
Many email clients are generating 8bit-encoded messages (Thunderbird, Mutt, etc) and people routinely use 8bit email every day. Avoiding it makes no longer any sense, and the current practice of using quoted-printable does not work right for non-latin aplhabets.
Please note that other software already implemented my proposal - see e.g. http://trac.edgewall.org/ticket/8252
comment:11 by , 15 years ago
Patch needs improvement: | unset |
---|
comment:12 by , 14 years ago
milestone: | → 1.3 |
---|
by , 14 years ago
Attachment: | 11212.1.diff added |
---|
comment:14 by , 14 years ago
Patch needs improvement: | unset |
---|
comment:15 by , 14 years ago
Severity: | → Normal |
---|---|
Type: | → Cleanup/optimization |
comment:16 by , 14 years ago
Easy pickings: | unset |
---|---|
Triage Stage: | Accepted → Ready for checkin |
Tests aren't optional. If you're changing code, you need tests - or a good excuse why a test isn't possible.