Code

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#11200 closed (fixed)

repeated icons in gmap javascript

Reported by: ludifan Owned by: jbronn
Component: GIS Version: master
Severity: Keywords: gmap
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

if several markers use the same icon it will be repeated as many times in the generated jacascript.

Attachments (4)

gmap.py.diff (8.8 KB) - added by ludifan 5 years ago.
gmap.diff (8.8 KB) - added by ludifan 5 years ago.
gmap.py (8.8 KB) - added by ludifan 5 years ago.
10838.diff (534 bytes) - added by ludifan 5 years ago.
this is the one (sorry for the mess...)

Download all attachments as: .zip

Change History (12)

Changed 5 years ago by ludifan

Changed 5 years ago by ludifan

Changed 5 years ago by ludifan

comment:1 Changed 5 years ago by ludifan

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 5 years ago by ludifan

  • Resolution set to fixed
  • Status changed from new to closed

the modification is at line 146 in icons property.

tried to add the .diff extension, but doesn't seem to work, sorry

the icon property returns a set which is a list of unique objects, this should do the trick

comment:3 Changed 5 years ago by dc

  • Resolution fixed deleted
  • Status changed from closed to reopened

bug is fixed only when patch is committed to trunk

comment:4 Changed 5 years ago by ludifan

  • Component changed from Contrib apps to GIS
  • Keywords GIS, removed

Changed 5 years ago by ludifan

this is the one (sorry for the mess...)

comment:5 Changed 5 years ago by jbronn

  • milestone set to 1.1
  • Owner changed from nobody to jbronn
  • Patch needs improvement set
  • Status changed from reopened to new
  • Triage Stage changed from Unreviewed to Accepted

Patch doesn't take into account GoogleMapSet, which I'll address when I commit.

comment:6 Changed 5 years ago by jbronn

  • Resolution set to fixed
  • Status changed from new to closed

(In r10865) Fixed #11200 -- Now use a set data structure for GoogleMap icons so that they aren't repeated in rendered JavaScript?. Thanks to ludifan for ticket and initial patch.

comment:7 Changed 5 years ago by ccahoon

(In [10992]) Fixed #11200 -- Now use a set data structure for GoogleMap icons so that they aren't repeated in rendered JavaScript. Thanks to ludifan for ticket and initial patch.

comment:8 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.