Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#11200 closed (fixed)

repeated icons in gmap javascript

Reported by: ludifan Owned by: jbronn
Component: GIS Version: master
Severity: Keywords: gmap
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

if several markers use the same icon it will be repeated as many times in the generated jacascript.

Attachments (4)

gmap.py.diff (8.8 KB) - added by ludifan 8 years ago.
gmap.diff (8.8 KB) - added by ludifan 8 years ago.
gmap.py (8.8 KB) - added by ludifan 8 years ago.
10838.diff (534 bytes) - added by ludifan 8 years ago.
this is the one (sorry for the mess...)

Download all attachments as: .zip

Change History (12)

Changed 8 years ago by ludifan

Attachment: gmap.py.diff added

Changed 8 years ago by ludifan

Attachment: gmap.diff added

Changed 8 years ago by ludifan

Attachment: gmap.py added

comment:1 Changed 8 years ago by ludifan

Has patch: set

comment:2 Changed 8 years ago by ludifan

Resolution: fixed
Status: newclosed

the modification is at line 146 in icons property.

tried to add the .diff extension, but doesn't seem to work, sorry

the icon property returns a set which is a list of unique objects, this should do the trick

comment:3 Changed 8 years ago by dc

Resolution: fixed
Status: closedreopened

bug is fixed only when patch is committed to trunk

comment:4 Changed 8 years ago by ludifan

Component: Contrib appsGIS
Keywords: GIS removed

Changed 8 years ago by ludifan

Attachment: 10838.diff added

this is the one (sorry for the mess...)

comment:5 Changed 8 years ago by jbronn

milestone: 1.1
Owner: changed from nobody to jbronn
Patch needs improvement: set
Status: reopenednew
Triage Stage: UnreviewedAccepted

Patch doesn't take into account GoogleMapSet, which I'll address when I commit.

comment:6 Changed 8 years ago by jbronn

Resolution: fixed
Status: newclosed

(In r10865) Fixed #11200 -- Now use a set data structure for GoogleMap icons so that they aren't repeated in rendered JavaScript?. Thanks to ludifan for ticket and initial patch.

comment:7 Changed 7 years ago by ccahoon

(In [10992]) Fixed #11200 -- Now use a set data structure for GoogleMap icons so that they aren't repeated in rendered JavaScript. Thanks to ludifan for ticket and initial patch.

comment:8 Changed 5 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top