Opened 17 years ago

Closed 17 years ago

Last modified 15 years ago

#11200 closed (fixed)

repeated icons in gmap javascript

Reported by: ludifan Owned by: jbronn
Component: GIS Version: dev
Severity: Keywords: gmap
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

if several markers use the same icon it will be repeated as many times in the generated jacascript.

Attachments (4)

gmap.py.diff​ (8.8 KB ) - added by ludifan 17 years ago.
gmap.diff​ (8.8 KB ) - added by ludifan 17 years ago.
gmap.py​ (8.8 KB ) - added by ludifan 17 years ago.
10838.diff​ (534 bytes ) - added by ludifan 17 years ago.
this is the one (sorry for the mess...)

Download all attachments as: .zip

Change History (12)

by ludifan, 17 years ago

Attachment: gmap.py.diff​ added

by ludifan, 17 years ago

Attachment: gmap.diff​ added

by ludifan, 17 years ago

Attachment: gmap.py​ added

comment:1 by ludifan, 17 years ago

Has patch: set

comment:2 by ludifan, 17 years ago

Resolution: → fixed
Status: new → closed

the modification is at line 146 in icons property.

tried to add the .diff extension, but doesn't seem to work, sorry

the icon property returns a set which is a list of unique objects, this should do the trick

comment:3 by dc, 17 years ago

Resolution: fixed
Status: closed → reopened

bug is fixed only when patch is committed to trunk

comment:4 by ludifan, 17 years ago

Component: Contrib apps → GIS
Keywords: GIS removed

by ludifan, 17 years ago

Attachment: 10838.diff​ added

this is the one (sorry for the mess...)

comment:5 by jbronn, 17 years ago

milestone: → 1.1
Owner: changed from nobody to jbronn
Patch needs improvement: set
Status: reopened → new
Triage Stage: Unreviewed → Accepted

Patch doesn't take into account GoogleMapSet, which I'll address when I commit.

comment:6 by jbronn, 17 years ago

Resolution: → fixed
Status: new → closed

(In r10865) Fixed #11200 -- Now use a set data structure for GoogleMap icons so that they aren't repeated in rendered JavaScript?. Thanks to ludifan for ticket and initial patch.

comment:7 by ccahoon, 17 years ago

(In [10992]) Fixed #11200 -- Now use a set data structure for GoogleMap icons so that they aren't repeated in rendered JavaScript. Thanks to ludifan for ticket and initial patch.

comment:8 by Jacob, 15 years ago

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top