Opened 6 years ago

Closed 3 years ago

#11184 closed Bug (fixed)

scripts/rpm-install.sh does not respect options passed to setup.py

Reported by: pgriess@… Owned by: nobody
Component: Uncategorized Version: 1.0
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Setuptools supports changing the target installation environment when building an RPM (setup.py bdist_rpm) with the --python or --fix-python options. These have the effect of changing the path to the python executable to invoke in the generated .spec file.

However, Django's setup.py specifies a custom installation script in scripts/rpm-install.sh, which always invokes python directly:

...
# This is what dist.py normally does.
python setup.py install --root=${RPM_BUILD_ROOT} --record="INSTALLED_FILES"
...

As a result, it's impossible to generate a Django install to target non-default environments.

Attachments (1)

t11184-r11366.patch (527 bytes) - added by rjc 5 years ago.
use ${python} instead of python in rpm-install.sh

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by kmtracey

  • milestone 1.1 deleted
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Not 1.1 material at this point.

comment:2 Changed 6 years ago by anonymous

This can be worked around by manually specifying the correct path in scripts/rpm-install.sh before running setup.py.

comment:3 Changed 6 years ago by Alex

  • Triage Stage changed from Unreviewed to Accepted

Changed 5 years ago by rjc

use ${python} instead of python in rpm-install.sh

comment:4 Changed 4 years ago by julien

  • Severity set to Normal
  • Type set to Bug

comment:5 Changed 3 years ago by aaugustin

  • Easy pickings unset
  • Triage Stage changed from Accepted to Ready for checkin
  • UI/UX unset

comment:6 Changed 3 years ago by aaugustin

  • Resolution set to fixed
  • Status changed from new to closed

In [17331]:

Fixed #11184 -- Made it possible to build RPMs with a non-default python executable.

Note: See TracTickets for help on using tickets.
Back to Top